Skip to content

Port zoneinfo module to use module state #99138

New issue
New issue
Closed
Closed
Port zoneinfo module to use module state#99138
Assignees
sobolevn
Labels
topic-subinterpreterstype-featureA feature request or enhancement
@sobolevn

Description

@sobolevn
sobolevn
opened on Nov 5, 2022

Feature or enhancement

Following https://github.com/ericsnowcurrently/multi-core-python/wiki/0-The-Plan we need to convert _zoneinfo to use module state.

Pitch

Right now there are several global objects:

cpython/Modules/_zoneinfo.c

Lines 23 to 25 in 47ab848

static PyObject *io_open = NULL;
static PyObject *_tzpath_find_tzfile = NULL;
static PyObject *_common_mod = NULL;

and

cpython/Modules/_zoneinfo.c

Lines 96 to 101 in 47ab848

static PyObject *TIMEDELTA_CACHE = NULL;
static PyObject *ZONEINFO_WEAK_CACHE = NULL;
static StrongCacheNode *ZONEINFO_STRONG_CACHE = NULL;
static size_t ZONEINFO_STRONG_CACHE_MAX_SIZE = 8;
static _ttinfo NO_TTINFO = {NULL, NULL, NULL, 0};

And one static type definition:

cpython/Modules/_zoneinfo.c

Line 93 in 47ab848

static PyTypeObject PyZoneInfo_ZoneInfoType;

If this is indeed planned to be fixed, I would love to work on it.

Metadata

Metadata

Assignees

Labels

topic-subinterpreterstype-featureA feature request or enhancement

Projects

Subinterpreters

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions