From 4bc124c303907c53e4bfd6ac5692efdd26e51e30 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 7 Dec 2022 16:24:01 +0300 Subject: [PATCH 1/5] gh-100072: only trigger netlify builds for doc changes --- .github/workflows/doc.yml | 3 ++- netlify.toml | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml index 44a1f206df1eb9..f4171888035047 100644 --- a/.github/workflows/doc.yml +++ b/.github/workflows/doc.yml @@ -21,9 +21,10 @@ on: - '3.8' - '3.7' paths: + - '.github/workflows/doc.yml' + # Should be in sync with `netlify.toml`: - 'Doc/**' - 'Misc/**' - - '.github/workflows/doc.yml' permissions: contents: read diff --git a/netlify.toml b/netlify.toml index 52675b3d701eb7..81ba6216219750 100644 --- a/netlify.toml +++ b/netlify.toml @@ -2,6 +2,9 @@ base = "Doc/" command = "make html" publish = "build/html" + # Do not trigger netlify builds if docs were not changed. + # Changed files should be in sync with `.github/workflows/doc.yml` + ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ./Doc ./Misc ./netlify.toml" [build.environment] PYTHON_VERSION = "3.8" From 5e3d116ab39683208095da3b237e5d269a17d92b Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Wed, 7 Dec 2022 17:46:27 +0300 Subject: [PATCH 2/5] Update netlify.toml --- netlify.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netlify.toml b/netlify.toml index 81ba6216219750..46ff9faa979fc6 100644 --- a/netlify.toml +++ b/netlify.toml @@ -4,8 +4,8 @@ publish = "build/html" # Do not trigger netlify builds if docs were not changed. # Changed files should be in sync with `.github/workflows/doc.yml` - ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ./Doc ./Misc ./netlify.toml" + ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF Doc/ netlify.toml" [build.environment] PYTHON_VERSION = "3.8" - IS_DEPLOYMENT_PREVIEW = "true" \ No newline at end of file + IS_DEPLOYMENT_PREVIEW = "true" From 3b5a8dfe603acb9f1ba48e5c68aba871f434d4a7 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Wed, 7 Dec 2022 17:46:46 +0300 Subject: [PATCH 3/5] Update doc.yml --- .github/workflows/doc.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml index f4171888035047..44a1f206df1eb9 100644 --- a/.github/workflows/doc.yml +++ b/.github/workflows/doc.yml @@ -21,10 +21,9 @@ on: - '3.8' - '3.7' paths: - - '.github/workflows/doc.yml' - # Should be in sync with `netlify.toml`: - 'Doc/**' - 'Misc/**' + - '.github/workflows/doc.yml' permissions: contents: read From 03c1dd1ed6551fcc5ce9ae816e7a2b306175d7c1 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Wed, 7 Dec 2022 21:14:22 +0300 Subject: [PATCH 4/5] Update netlify.toml --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index 46ff9faa979fc6..5519160dc6a066 100644 --- a/netlify.toml +++ b/netlify.toml @@ -4,7 +4,7 @@ publish = "build/html" # Do not trigger netlify builds if docs were not changed. # Changed files should be in sync with `.github/workflows/doc.yml` - ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF Doc/ netlify.toml" + ignore = "git diff --name-only $CACHED_COMMIT_REF $COMMIT_REF | grep -q '^(Doc\/|netlify\.toml)' && exit 1 || exit 0" [build.environment] PYTHON_VERSION = "3.8" From 35c4b75b09f9165e6aade3dd1653525cd6e4153e Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Wed, 7 Dec 2022 21:25:36 +0300 Subject: [PATCH 5/5] Update netlify.toml Co-authored-by: Hugo van Kemenade --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index 5519160dc6a066..f5790fc5fec74f 100644 --- a/netlify.toml +++ b/netlify.toml @@ -4,7 +4,7 @@ publish = "build/html" # Do not trigger netlify builds if docs were not changed. # Changed files should be in sync with `.github/workflows/doc.yml` - ignore = "git diff --name-only $CACHED_COMMIT_REF $COMMIT_REF | grep -q '^(Doc\/|netlify\.toml)' && exit 1 || exit 0" + ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../netlify.toml" [build.environment] PYTHON_VERSION = "3.8"