Skip to content

gh-110964: clinic: refactor output_templates() #110982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

gh-110964: clinic: refactor output_templates() #110982

merged 1 commit into from
Oct 20, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 17, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 17, 2023
Closed
@vstinner vstinner mentioned this pull request Oct 17, 2023
Merged
@vstinner
Copy link
Member Author

Refactor the code to avoid if clinic is not None. This change basically just move code and remove if clinic is not None.

@vstinner vstinner force-pushed the clinic_output_templates branch from 3f5b550 to e6cebdb Compare October 17, 2023 12:49
@vstinner
Copy link
Member Author

cc @AlexWaygood

erlend-aasland
erlend-aasland approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you fine with this, @AlexWaygood?

@AlexWaygood
Copy link
Member

Are you fine with this, @AlexWaygood?

Haven't had a chance to review in depth, but this looks fine to me -- feel free to merge if you're happy!

@vstinner vstinner merged commit 0937b11 into python:main Oct 20, 2023
@vstinner vstinner deleted the clinic_output_templates branch October 20, 2023 21:42
@vstinner
Copy link
Member Author

Merged, thanks for reviews.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-110964: clinic: refactor output_templates() (python#110982)
11d383b
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110964: clinic: refactor output_templates() (python#110982)
91ce311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @AlexWaygood @erlend-aasland