Skip to content

gh-117411: move PyFutureFeatures to pycore_symtable.h and make it private #117412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Mar 31, 2024

PyFutureFeatures is not used by any public APIs, so nobody should be relying on it.

Also move _PyCompilerSrcLocation along with it, and rename to _Py_SourceLocation so the symtable can use it.

Fixes #117411.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the source location structure uses a private structure.

@iritkatriel iritkatriel enabled auto-merge (squash) April 2, 2024 10:07
@iritkatriel iritkatriel merged commit 1d5479b into python:main Apr 2, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyFutureFeatures should not be public
3 participants