gh-119714: Add PyLong_GetNumBits() function #119715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+726
to
+747
| self.assertEqual(numbits(0), 0) | ||
| self.assertEqual(numbits(7), 3) | ||
| self.assertEqual(numbits(-37), 6) | ||
| self.assertEqual(numbits(684_643_661_981), 40) | ||
| self.assertEqual(numbits(2**123-1), 123) |
There was a problem hiding this comment.
There are no tests for the two overflow cases.
There was a problem hiding this comment.
I added a test, but it requires 1145324612.3 GiB of memory to run :-) On 32-bit systems, the test pass and only requires 273 MiB.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
PR rebased to fix merge conflicts with the main branch (with the new PyLong_GetSign() function). |
|
The C API Working Group rejected this API: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--119715.org.readthedocs.build/