Skip to content

gh-121300: Add replace to copy.__all__ #121302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 3, 2024
Merged

gh-121300: Add replace to copy.__all__ #121302

merged 6 commits into from
Jul 3, 2024

Conversation

max-muoto
Copy link
Contributor

@max-muoto max-muoto commented Jul 3, 2024 •
edited by bedevere-app bot
Loading

Adds missing replace to copy.__all__

@ghost
Copy link

ghost commented Jul 3, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jul 3, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) July 3, 2024 05:43
pygeek
pygeek reviewed Jul 3, 2024
View reviewed changes
Lib/copy.py
@@ -56,7 +56,7 @@ class Error(Exception):
pass
error = Error # backward compatibility

__all__ = ["Error", "copy", "deepcopy"]
__all__ = ["Error", "copy", "deepcopy", "replace"]
Copy link
Contributor

@pygeek pygeek Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression test so this doesn't happen again. See helper method support.test__all__ in the test directory—it automatically detects public methods based on whether they follow the public name convention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me go ahead, good callout.

@max-muoto max-muoto disabled auto-merge July 3, 2024 05:50
@max-muoto
Copy link
Contributor Author

@serhiy-storchaka If you want to take another look.

Eclips4
Eclips4 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kumaraditya303 kumaraditya303 merged commit 7c66906 into python:main Jul 3, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @max-muoto for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2024
@max-muoto @miss-islington
pythongh-121300: Add replace to copy.__all__ (pythonGH-121302)
1d975af 
(cherry picked from commit 7c66906)

Co-authored-by: Max Muoto <maxmuoto@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

GH-121337 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2024
JelleZijlstra pushed a commit that referenced this pull request Jul 3, 2024
@miss-islington @max-muoto
[3.13] gh-121300: Add replace to copy.__all__ (GH-121302) (#121337)
8799f05 
(cherry picked from commit 7c66906)

Co-authored-by: Max Muoto <maxmuoto@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 7c66906.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/8418) and take a look at the build logs.
  4. Check if the failure is related to this commit (7c66906) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/8418

Failed tests:

  • test_repl

Failed subtests:

  • test_asyncio_repl_is_ok - test.test_repl.TestInteractiveInterpreter.test_asyncio_repl_is_ok

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_repl.py", line 199, in test_asyncio_repl_is_ok
    assert_python_ok("-m", "asyncio")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line 182, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line 167, in _assert_python
    res.fail(cmd_line)
    ~~~~~~~~^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line 80, in fail
    raise AssertionError(f"Process return code is {exitcode}\n"
    ...<10 lines>...
                         f"---")
AssertionError: Process return code is -6 (SIGABRT)
command line: ['/root/buildarea/3.x.angelico-debian-amd64/build/python', '-X', 'faulthandler', '-I', '-m', 'asyncio']


Traceback (most recent call last):
xiting asyncio REPL...
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/asyncio/__main__.py", line 109, in run
    raise OSError(errno.ENOTTY, "tty required", "stdin")
Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads
Python runtime state: finalizing (tstate=0x0000562ad21ccb50)


Traceback (most recent call last):
xiting asyncio REPL...
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/asyncio/__main__.py", line 109, in run
    raise OSError(errno.ENOTTY, "tty required", "stdin")
Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads
Python runtime state: finalizing (tstate=0x000055c24a873b50)

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@max-muoto @noahbkim
pythongh-121300: Add replace to copy.__all__ (python#121302)
ec9fba1
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@max-muoto @estyxx
pythongh-121300: Add replace to copy.__all__ (python#121302)
36a7668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pygeek pygeek pygeek left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@max-muoto @bedevere-bot @pygeek @JelleZijlstra @serhiy-storchaka @kumaraditya303 @Eclips4