Skip to content

[3.13] NEWS: Fix Sphinx warnings and increase threshold for new news nits (GH-121482) #121513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2024
Merged

[3.13] NEWS: Fix Sphinx warnings and increase threshold for new news nits (GH-121482) #121513

merged 3 commits into from
Jul 13, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 8, 2024 •
edited by github-actions bot
Loading

(cherry picked from commit 006b53a)

📚 Documentation preview 📚: https://cpython-previews--121513.org.readthedocs.build/

@hugovk @AlexWaygood
[3.13] NEWS: Fix Sphinx warnings and increase threshold for new news …
e3e24db 
…nits (pythonGH-121482)

(cherry picked from commit 006b53a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Jul 8, 2024
Merged
hugovk
hugovk commented Jul 8, 2024
View reviewed changes
@hugovk
Copy link
Member Author

hugovk commented Jul 8, 2024

TODO check this:

/home/runner/work/cpython/cpython/Doc/library/profile.rst:699: WARNING: py:class reference target not found: cProfile.Profile

https://github.com/python/cpython/actions/runs/9846534114/job/27184520922?pr=121513#step:7:22

@hugovk hugovk enabled auto-merge (squash) July 13, 2024 12:49
@hugovk hugovk merged commit fcc4a53 into python:3.13 Jul 13, 2024
26 checks passed
@hugovk hugovk deleted the backport-006b53a-3.13 branch July 13, 2024 12:55
@hugovk
Copy link
Member Author

hugovk commented Jul 13, 2024

TODO check this:

/home/runner/work/cpython/cpython/Doc/library/profile.rst:699: WARNING: py:class reference target not found: cProfile.Profile

python/cpython/actions/runs/9846534114/job/27184520922?pr=121513#step:7:22

This was only a warning, the real error was about the threshold:

Error: new NEWS nits:

/home/runner/work/cpython/cpython/build/NEWS:1403: WARNING: py:func reference target not found: posixpath.relpath
/home/runner/work/cpython/cpython/build/NEWS:1406: WARNING: py:func reference target not found: mailbox.mbox.flush
/home/runner/work/cpython/cpython/build/NEWS:1412: WARNING: py:meth reference target not found: asyncio.asyncio.run_coroutine_threadsafe
/home/runner/work/cpython/cpython/build/NEWS:1412: WARNING: py:class reference target not found: CancelledError
/home/runner/work/cpython/cpython/build/NEWS:1412: WARNING: py:class reference target not found: InvalidStateError
/home/runner/work/cpython/cpython/build/NEWS:1416: WARNING: py:func reference target not found: ntpath.commonpath
/home/runner/work/cpython/cpython/build/NEWS:1424: WARNING: py:meth reference target not found: configparser.RawConfigParser._read
/home/runner/work/cpython/cpython/build/NEWS:1427: WARNING: py:func reference target not found: ntpath.commonpath
/home/runner/work/cpython/cpython/build/NEWS:1484: WARNING: py:func reference target not found: inspect.findsource
/home/runner/work/cpython/cpython/build/NEWS:1554: WARNING: py:class reference target not found: tkinter.Checkbutton
/home/runner/work/cpython/cpython/build/NEWS:1554: WARNING: py:class reference target not found: tkinter.ttk.Checkbutton
/home/runner/work/cpython/cpython/build/NEWS:1568: WARNING: py:class reference target not found: logging.TimedRotatingFileHandler

@hugovk hugovk mentioned this pull request Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugovk