Skip to content

bpo-36251: Fix format strings used in match_repr() and stdprinter_repr() #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2019
Merged

bpo-36251: Fix format strings used in match_repr() and stdprinter_repr() #12252

merged 4 commits into from
Mar 10, 2019

Conversation

sth
Copy link
Contributor

@sth sth commented Mar 9, 2019 •
edited by bedevere-bot
Loading

In match_repr(), the marks are Py_ssize_t, not int.

In stdprinter_repr(), the argument is a pointer and the correct format specifier for that is %p (this includes the 0x prefix).

For reference: The docs for PyUnicode_FromFormat

https://bugs.python.org/issue36251

sth added 2 commits March 9, 2019 15:33
@sth
Fix format string in MatchObject repr
2ba088d 
The `mark`s are Py_ssize_t, not `int`. The correct format specifier for
that is %zd.
@sth
Fix format string in StdPrinter repr
496648a 
The appropriate format specifier to print a pointer as 0x.... is %p.
serhiy-storchaka
serhiy-storchaka approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that it is better to use names visible from the Python side, because readers of the changelog are Python users.

@serhiy-storchaka serhiy-storchaka merged commit 8b91eda into python:master Mar 10, 2019
@miss-islington
Copy link
Contributor

Thanks @sth for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Mar 10, 2019
@bedevere-bot
Copy link

GH-12263 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2019
@sth @miss-islington
bpo-36251: Fix format strings used in match_repr() and stdprinter_rep…
90426a6 
…r(). (pythonGH-12252)

(cherry picked from commit 8b91eda)

Co-authored-by: sth <sth.dev@tejp.de>
miss-islington added a commit that referenced this pull request Mar 10, 2019
@miss-islington @sth
bpo-36251: Fix format strings used in match_repr() and stdprinter_rep…
e4be205 
…r(). (GH-12252)

(cherry picked from commit 8b91eda)

Co-authored-by: sth <sth.dev@tejp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sth @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni