Skip to content

[3.13] gh-123968: Fix lower bound for python -m random --float (GH-123971) #124009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 12, 2024

Fixes #123968.

(cherry picked from commit a362c41)

Co-authored-by: Anders Kaseorg andersk@mit.edu

…onGH-123971)

(cherry picked from commit a362c41)

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@Yhg1s
Copy link
Member

Yhg1s commented Sep 23, 2024

Given that this is a new feature, yeah, let's get the fix into 3.13.0 so people don't end up relying on the less desirable behaviour.

@Yhg1s Yhg1s merged commit 7b8affa into python:3.13 Sep 23, 2024
39 checks passed
@mahlzahn
Copy link
Contributor

The current docs do not reflect this fix, yet:
https://docs.python.org/3.13/library/random.html#random-cli

-f
--float
Print a random floating-point number between 1 and N inclusive, using uniform().

@hugovk
Copy link
Member

hugovk commented Sep 25, 2024

It's because this PR did not update the docs.

@mahlzahn, would you like to create a PR to fix it?

This is the file to edit:
https://github.com/python/cpython/blob/main/Doc/library/random.rst

No need for a news entry, and we can reuse issue number gh-123968 for the PR title prefix.

nanjekyejoannah pushed a commit that referenced this pull request Sep 25, 2024
* fix -f/--float command line option description

See gh-123968 gh-124009

* Update Doc/library/random.rst

---------

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
…onGH-124517)

* fix -f/--float command line option description

See pythongh-123968 pythongh-124009

* Update Doc/library/random.rst

---------

(cherry picked from commit f8651a2)

Co-authored-by: Robert Wolff <mahlzahn@posteo.de>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Yhg1s pushed a commit that referenced this pull request Sep 26, 2024
…124517) (#124523)

gh-123968: fix -f/--float command line option description (GH-124517)

* fix -f/--float command line option description

See gh-123968 gh-124009

* Update Doc/library/random.rst

---------

(cherry picked from commit f8651a2)

Co-authored-by: Robert Wolff <mahlzahn@posteo.de>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants