Skip to content

gh-124212 fix invalid variable name in test_venv.py #124211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2024
Merged

gh-124212 fix invalid variable name in test_venv.py #124211

merged 5 commits into from
Sep 18, 2024
+17 −1

Conversation

JacekDuszenko
Copy link
Contributor

@JacekDuszenko JacekDuszenko commented Sep 18, 2024 •
edited by bedevere-app bot
Loading

Fix an invalid variable name from dst to dest. Add a test covering that code path

@JacekDuszenko JacekDuszenko changed the title fix invalid variable name in test_venv.py gh-124212 fix invalid variable name in test_venv.py Sep 18, 2024
@JacekDuszenko JacekDuszenko mentioned this pull request Sep 18, 2024
Closed
@JacekDuszenko
Copy link
Contributor Author

@zooba could you please take a look? These are mostly your changes so you might be the best person to review. Thanks!

@Eclips4 Eclips4 requested a review from zooba September 18, 2024 18:05
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Sep 18, 2024
@JacekDuszenko @Eclips4
Update Misc/NEWS.d/next/Library/2024-09-18-17-45-52.gh-issue-124212.n…
d8ea2d3 
…6kIby.rst

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@zooba
Copy link
Member

zooba commented Sep 18, 2024

LGTM

@zooba zooba enabled auto-merge (squash) September 18, 2024 21:41
@zooba zooba merged commit ea7fe1f into python:main Sep 18, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @JacekDuszenko for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@JacekDuszenko @miss-islington
pythongh-124212: Fix undefined variable in error message in venv (pyt…
c3db7a5 
…honGH-124211)

(cherry picked from commit ea7fe1f)

Co-authored-by: Jacek <jacek.duszenko@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2024

GH-124226 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 18, 2024
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@JacekDuszenko @savannahostrowski
pythongh-124212: Fix undefined variable in error message in venv (pyt…
6926be2 
…honGH-124211)
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @JacekDuszenko
[3.13] gh-124212: Fix undefined variable in error message in venv (GH…
32acfdb 
…-124211) (#124226)

gh-124212: Fix undefined variable in error message in venv (GH-124211)
(cherry picked from commit ea7fe1f)

Co-authored-by: Jacek <jacek.duszenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacekDuszenko @zooba @Eclips4