Skip to content

gh-124445: Allow specializing generic ParamSpec aliases #124512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 3, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Sep 25, 2024

I think I more or less understood how this is supposed to work, but please let me know if I missed something :)
Also, if you think I should add more tests.

@tomasr8
Copy link
Member Author

tomasr8 commented Sep 25, 2024

Just trying to debug this weird error now:

Objects/tupleobject.c:408: _PyObject_GC_TRACK: Assertion "!_PyObject_GC_IS_TRACKED(((PyObject*)(op)))" failed: object already tracked by the garbage collector                                
Fatal Python error: Segmentation fault

Unfortunately seems to only happen when running the tests, not when I run the test case as a script :/

tomasr8 and others added 2 commits September 25, 2024 22:05
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@tomasr8
Copy link
Member Author

tomasr8 commented Sep 26, 2024

Ready for another round :)

tomasr8 and others added 3 commits September 29, 2024 16:16
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@tomasr8 tomasr8 requested a review from Daraan November 16, 2024 21:59
@tomasr8
Copy link
Member Author

tomasr8 commented Feb 2, 2025

ping @JelleZijlstra in case you forgot about this 🙂

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm going to run refleak tests locally to make sure I'm not missing something.

@JelleZijlstra JelleZijlstra merged commit bbf1979 into python:main Mar 3, 2025
46 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Installed with X 3.x (no tier) has failed when building commit bbf1979.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1244/builds/4460) and take a look at the build logs.
  4. Check if the failure is related to this commit (bbf1979) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1244/builds/4460

Failed tests:

  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolForkserverProcessPoolExecutorTest.test_force_shutdown_workers

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-debian-x86.installed/build/target/lib/python3.14/test/test_importlib/metadata/fixtures.py", line 391, in _inner
    func(self, **args)
    ~~~~^^^^^^^^^^^^^^
  File "/buildbot/buildarea/3.x.ware-debian-x86.installed/build/target/lib/python3.14/test/test_concurrent_futures/test_process_pool.py", line 281, in test_force_shutdown_workers
    self.assertEqual(worker_process.exitcode, -signal.SIGKILL)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 255 != -9

@tomasr8 tomasr8 deleted the paramspec-alias branch March 4, 2025 08:37
@tomasr8
Copy link
Member Author

tomasr8 commented Mar 4, 2025

Buildbot failure seems unrelated

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…#124512)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants