Skip to content

gh-127146: Fix test_sysconfigdata_json for Emscripten #128556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jan 6, 2025

We should set the value of prefix and exec_prefix in the host from host_prefix and host_exec_prefix.

We should set the value of prefix and exec_prefix in the host from
host_prefix and host_exec_prefix.
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Yes, I was just looking at this too when working on GH-128558. Good catch!

@FFY00 FFY00 merged commit b6c919b into python:main Jan 6, 2025
44 checks passed
@hoodmane hoodmane deleted the sysconfig-test-2 branch January 6, 2025 20:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane
Copy link
Contributor Author

@Fy00 I'm still getting an error with a diff like:

-  'py_version_short': '3.14'}
+  'py_version_short': '3.14',
?                            ^
+  'userbase': '/home/rchatham/.local'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants