Skip to content

[3.13] gh-128632: fix segfault on nested __classdict__ type param (GH-128744) #132085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Apr 4, 2025

@tom-pytel
Copy link
Contributor Author

Ping @ZeroIntensity, Hey sorry to bug you but I screwed up cherry picker again. The PR is fine but like an idiot I deleted the title stuff because it looked like boilerplate. Already tried to redo the PR and can't because it is here already :(

@ZeroIntensity ZeroIntensity changed the title Backport 891c61c 3.13 [3.13] gh-128632: fix segfault on nested __classdict__ type param (GH-128744) Apr 4, 2025
@ZeroIntensity
Copy link
Member

Fixed the title. Do you lack permissions to change the title on your own PR? If so, there's probably a setting we should change.

@tom-pytel
Copy link
Contributor Author

tom-pytel commented Apr 4, 2025

Fixed the title. Do you lack permissions to change the title on your own PR? If so, there's probably a setting we should change.

No but I thought that title that was set by cherry picker was the one that was needed since it was so specific. All I did was add the issue number to the empty description. Thx...

@ZeroIntensity
Copy link
Member

Ah, no worries. There's a title line and description that cherry-picker prints out when it pushes, which you're supposed to manually set as the title.

@JelleZijlstra JelleZijlstra merged commit 900dc2b into python:3.13 Apr 4, 2025
69 of 72 checks passed
@tom-pytel tom-pytel deleted the backport-891c61c-3.13 branch April 4, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants