From 9887f3c6b6000d532c8de2717fe0e6e8566a5db3 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Fri, 25 Apr 2025 15:35:01 +0200 Subject: [PATCH] gh-132912: Use SHORT_TIMEOUT in test_remote_pdb Replace hardcoded timeout of 5 seconds with SHORT_TIMEOUT. --- Lib/test/test_remote_pdb.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Lib/test/test_remote_pdb.py b/Lib/test/test_remote_pdb.py index d3267be79ece0e..1889afb8642ae4 100644 --- a/Lib/test/test_remote_pdb.py +++ b/Lib/test/test_remote_pdb.py @@ -12,7 +12,7 @@ import unittest.mock from contextlib import contextmanager from pathlib import Path -from test.support import is_wasi, os_helper +from test.support import is_wasi, os_helper, SHORT_TIMEOUT from test.support.os_helper import temp_dir, TESTFN, unlink from typing import Dict, List, Optional, Tuple, Union, Any @@ -414,7 +414,7 @@ def test_connect_and_basic_commands(self): self._send_command(client_file, "c") # Wait for process to finish - stdout, _ = process.communicate(timeout=5) + stdout, _ = process.communicate(timeout=SHORT_TIMEOUT) # Check if we got the expected output self.assertIn("Function returned: 42", stdout) @@ -457,7 +457,7 @@ def test_breakpoints(self): # Continue to end self._send_command(client_file, "c") - stdout, _ = process.communicate(timeout=5) + stdout, _ = process.communicate(timeout=SHORT_TIMEOUT) self.assertIn("Function returned: 42", stdout) self.assertEqual(process.returncode, 0) @@ -466,7 +466,7 @@ def test_keyboard_interrupt(self): """Test that sending keyboard interrupt breaks into pdb.""" synchronizer_sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) synchronizer_sock.bind(('127.0.0.1', 0)) # Let OS assign port - synchronizer_sock.settimeout(5) + synchronizer_sock.settimeout(SHORT_TIMEOUT) synchronizer_sock.listen(1) self.addCleanup(synchronizer_sock.close) sync_port = synchronizer_sock.getsockname()[1] @@ -521,7 +521,7 @@ def bar(): # Continue to end self._send_command(client_file, "iterations = 0") self._send_command(client_file, "c") - stdout, _ = process.communicate(timeout=5) + stdout, _ = process.communicate(timeout=SHORT_TIMEOUT) self.assertIn("Function returned: 42", stdout) self.assertEqual(process.returncode, 0) @@ -539,7 +539,7 @@ def test_handle_eof(self): client_file.flush() # The process should complete normally after receiving EOF - stdout, stderr = process.communicate(timeout=5) + stdout, stderr = process.communicate(timeout=SHORT_TIMEOUT) # Verify process completed correctly self.assertIn("Function returned: 42", stdout) @@ -589,7 +589,7 @@ def run_test(): self.assertIn('protocol version', message['message']) # The process should complete normally - stdout, stderr = process.communicate(timeout=5) + stdout, stderr = process.communicate(timeout=SHORT_TIMEOUT) # Verify the process completed successfully self.assertIn("Test result: True", stdout) @@ -631,7 +631,7 @@ def test_help_system(self): # Continue execution to finish the program self._send_command(client_file, "c") - stdout, stderr = process.communicate(timeout=5) + stdout, stderr = process.communicate(timeout=SHORT_TIMEOUT) self.assertIn("Function returned: 42", stdout) self.assertEqual(process.returncode, 0) @@ -689,7 +689,7 @@ def test_multi_line_commands(self): # Continue execution to finish self._send_command(client_file, "c") - stdout, stderr = process.communicate(timeout=5) + stdout, stderr = process.communicate(timeout=SHORT_TIMEOUT) self.assertIn("Function returned: 42", stdout) self.assertEqual(process.returncode, 0)