Skip to content

gh-91048: Chain some exceptions in _testexternalinspection.c #132970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-91048: Chain some exceptions in _testexternalinspection.c #132970

wants to merge 8 commits into from
+52 −33

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Apr 25, 2025 •
edited
Loading

  1. Added extra Py_UNREACHABLE calls on unsupported platforms
  2. Remove unused refcnt read
  3. Set result to 0 if fd closing failed
  4. Chain some exceptions to get more info if failed

@sergey-miryanov sergey-miryanov changed the title Chain some exceptions in _testexternalinspection.c gh-91048: Chain some exceptions in _testexternalinspection.c Apr 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2025
Open
@sergey-miryanov sergey-miryanov marked this pull request as ready for review April 25, 2025 21:00
@sergey-miryanov
Copy link
Contributor Author

@pablogsal Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergey-miryanov @picnixz