Skip to content

gh-133167: Fix compilation process with --enable-optimizations and --without-docstrings #133187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

gh-133167: Fix compilation process with --enable-optimizations and --without-docstrings #133187

merged 1 commit into from
Apr 30, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 30, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from vstinner April 30, 2025 07:25
@sobolevn sobolevn requested a review from rhettinger as a code owner April 30, 2025 07:25
@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2025
Closed
@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Apr 30, 2025
vstinner
vstinner reviewed Apr 30, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're fixing tests on Python built with --without-docstrings, you can also fix:

test_inspect
test_pydoc
test_descr
test_rlcompleter

@sobolevn
Copy link
Member Author

sobolevn commented Apr 30, 2025 •
edited
Loading

@vstinner compilation does not fail without --enable-optimizations, so it is related. Basically it needs to execute tests to get profile data. But, tests fail.

Tests that you've mentioned are not executed during --enable-optimizations build phase. I would prefer to fix them in the next PR. Since it would only be a test fix.

What do you think? :)

vstinner
vstinner approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm fine with fixing other tests in a follow-up PR, and leaving the NEWS entry unchanged.

@sobolevn sobolevn merged commit cc39b19 into python:main Apr 30, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2025
@sobolevn @miss-islington
pythongh-133167: Fix compilation process with `--enable-optimizations…
90c5fc1 
…` and `--without-docstrings` (pythonGH-133187)

(cherry picked from commit cc39b19)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Apr 30, 2025

GH-133207 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 30, 2025
@sobolevn
Copy link
Member Author

Thank you! Working on other tests 👍

sobolevn added a commit that referenced this pull request Apr 30, 2025
@miss-islington @sobolevn
[3.13] gh-133167: Fix compilation process with `--enable-optimization…
704a3f8 
…s` and `--without-docstrings` (GH-133187) (#133207)

gh-133167: Fix compilation process with `--enable-optimizations` and `--without-docstrings` (GH-133187)
(cherry picked from commit cc39b19)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @vstinner