gh-61103: don't use native complex types in ctypes #133237
Open
+54
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…struct module Each complex type interpreted as an array type containing exactly two elements of the corresponding real type (real and imaginary parts, respectively).
…ctypes * drop _complex.h header * use appropriate real arrays to replace complex types
efbe0bb to
6a20faf
Compare
dalcinl
reviewed
May 1, 2025
|
@skirpichev Thanks, it looks great. IMHO, and despite your doubts about worthiness, this should be merged. Things are simpler now, you removed lots of code, and a private header.
|
dalcinl
reviewed
May 1, 2025
Co-authored-by: Lisandro Dalcin <dalcinl@gmail.com>
encukou
reviewed
May 1, 2025
Co-authored-by: Petr Viktorin <encukou@gmail.com>
dalcinl
approved these changes
May 1, 2025
Misc/NEWS.d/next/Library/2025-04-25-16-20-49.gh-issue-121249.uue2nK.rst
Outdated
Show resolved
Hide resolved
…ue2nK.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 071d57e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133237%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
encukou
reviewed
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--133237.org.readthedocs.build/
Note, that
Py_FFI_SUPPORT_C_COMPLEXcheck configure check imply support for complex types. So,Py_HAVE_C_COMPLEXcheck is redundant. Though, I'm not sure if it worth removing.