gh-133410: Fix PR detection in build workflow #133671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
May 15, 2025
| @@ -57,7 +57,7 @@ class Outputs: | |||
|
|
|||
| def compute_changes() -> None: | |||
| target_branch, head_ref = git_refs() | |||
| if target_branch and head_ref: | |||
| if os.environ.get("GITHUB_EVENT_NAME", "") == "pull_request": | |||
There was a problem hiding this comment.
I think that this should be and
Suggested change
| if os.environ.get("GITHUB_EVENT_NAME", "") == "pull_request": | |
| if ( | |
| target_branch | |
| and head_ref | |
| and os.environ.get("GITHUB_EVENT_NAME", "") == "pull_request" | |
| ): |
There was a problem hiding this comment.
See #133410 (comment), the original problem is that target_branch and head_ref are always be truthy, so I don't think we need to check them.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 15, 2025
(cherry picked from commit 319acf3) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 15, 2025
(cherry picked from commit 319acf3) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-134054 is a backport of this pull request to the 3.13 branch. |
|
GH-134055 is a backport of this pull request to the 3.14 branch. |
hugovk
added a commit
that referenced
this pull request
May 15, 2025
hugovk
added a commit
that referenced
this pull request
May 15, 2025
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 15, 2025
(cherry picked from commit 319acf3) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-134057 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's running on my fork: https://github.com/hugovk/cpython/actions/runs/14908903403/job/41878001194#step:6:16
And on this PR: https://github.com/python/cpython/actions/runs/14909052522/job/41878505661?pr=133671#step:6:19
Tools/build/compute-changes.pylooks at the wrong branches #133410