From 43c28e2fdc247597436f0252d7bb4392b267fc38 Mon Sep 17 00:00:00 2001 From: sharktide Date: Thu, 8 May 2025 17:45:30 -0400 Subject: [PATCH 1/2] Do not run test_cli_with_metadata_encoding_extract if system encoding is not UTF8 --- Lib/test/test_zipfile/test_core.py | 1 + 1 file changed, 1 insertion(+) diff --git a/Lib/test/test_zipfile/test_core.py b/Lib/test/test_zipfile/test_core.py index ae898150658565..2ba66cf70bfaad 100644 --- a/Lib/test/test_zipfile/test_core.py +++ b/Lib/test/test_zipfile/test_core.py @@ -3631,6 +3631,7 @@ def test_cli_with_metadata_encoding(self): for name in self.file_names: self.assertIn(name, listing) + @unittest.skipIf(locale.getpreferredencoding().lower() != 'utf-8', 'test requires utf-8') def test_cli_with_metadata_encoding_extract(self): os.mkdir(TESTFN2) self.addCleanup(rmtree, TESTFN2) From 7bc7bd9c0131c8186558378e35e3207afdfdc155 Mon Sep 17 00:00:00 2001 From: Rihaan Meher Date: Thu, 8 May 2025 18:18:18 -0400 Subject: [PATCH 2/2] Add import statements --- Lib/test/test_zipfile/test_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_zipfile/test_core.py b/Lib/test/test_zipfile/test_core.py index 2ba66cf70bfaad..fbd89995fd05b0 100644 --- a/Lib/test/test_zipfile/test_core.py +++ b/Lib/test/test_zipfile/test_core.py @@ -4,6 +4,7 @@ import importlib.util import io import itertools +import locale import os import posixpath import stat @@ -31,7 +32,6 @@ ) from test.support.import_helper import ensure_lazy_imports - TESTFN2 = TESTFN + "2" TESTFNDIR = TESTFN + "d" FIXEDTEST_SIZE = 1000