Skip to content

gh-133741: Check strace version in support.strace_helper #133763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-133741: Check strace version in support.strace_helper #133763

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 9, 2025 •
edited by bedevere-app bot
Loading

Need strace 5.5 or newer for the --trace option.

@vstinner
pythongh-133741: Check strace version in support.strace_helper
f035b67 
Need strace 5.5 or newer for the --trace option.
@vstinner vstinner marked this pull request as ready for review May 9, 2025 14:18
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2025
Closed
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label May 9, 2025
@vstinner
Copy link
Member Author

vstinner commented May 9, 2025

Python 3.13 test_subprocess uses a different strategy: it runs strace on the /bin/true program to check if strace works.

My PR parses the strace version from strace -V output.

@cmaloney
Copy link
Contributor

cmaloney commented May 9, 2025

Could the version check go inside _can_strace (https://github.com/python/cpython/pull/133763/files#diff-f46934bbb48e17e6a386e49dd7375e2e5542c5d529bcadae34f3bb1e3575d3b5R203-R210). That already does a cache variable. Definitely like the approach of just disable on older strace versions.

@vstinner
Copy link
Member Author

vstinner commented May 9, 2025

Could the version check go inside _can_strace

I wrote a simpler change: #133766

@vstinner vstinner closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @cmaloney