From b60e48c5d9064b585ec0f22c87efada1f09b9e77 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 12 May 2025 20:54:22 +0300 Subject: [PATCH 1/2] gh-133885: skip `test_compress_locking` in `test_zstd` --- Lib/test/test_zstd.py | 1 + 1 file changed, 1 insertion(+) diff --git a/Lib/test/test_zstd.py b/Lib/test/test_zstd.py index 541db4441b035c..fd7b14db644c03 100644 --- a/Lib/test/test_zstd.py +++ b/Lib/test/test_zstd.py @@ -2432,6 +2432,7 @@ def test_buffer_protocol(self): class FreeThreadingMethodTests(unittest.TestCase): + @unittest.skip("it fails for now, see gh-133885") @unittest.skipUnless(Py_GIL_DISABLED, 'this test can only possibly fail with GIL disabled') @threading_helper.reap_threads @threading_helper.requires_working_threading() From 909393920ff432d18b584ade32e5f264d83a67d0 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 12 May 2025 21:48:09 +0300 Subject: [PATCH 2/2] Address review --- Lib/test/test_zstd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_zstd.py b/Lib/test/test_zstd.py index fd7b14db644c03..53ca592ea38828 100644 --- a/Lib/test/test_zstd.py +++ b/Lib/test/test_zstd.py @@ -2430,9 +2430,9 @@ def test_buffer_protocol(self): self.assertEqual(f.write(arr), LENGTH) self.assertEqual(f.tell(), LENGTH) +@unittest.skip("it fails for now, see gh-133885") class FreeThreadingMethodTests(unittest.TestCase): - @unittest.skip("it fails for now, see gh-133885") @unittest.skipUnless(Py_GIL_DISABLED, 'this test can only possibly fail with GIL disabled') @threading_helper.reap_threads @threading_helper.requires_working_threading()