gh-134939: Add the interpreters Module #133958
Conversation
7ddfb50 to
5c8545a
Compare
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5c8545a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
1e34abd to
c63b6bc
Compare
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c63b6bc 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
c63b6bc to
ea9041c
Compare
|
FTR, I ran this against the buildbots and there were two failures:
Neither looks related, but I'll rerun them just to be sure. |
ea9041c to
0a5d0e4
Compare
|
!buildbot aarch64 RHEL8 Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot wasm32-wasi Non-Debug |
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 491a642 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
!buildbot AMD64.Windows11.Non-Debug.PR|AMD64.Windows11.Refleaks.PR|PPC64LE.Fedora.Stable.Clang.Installed.PR|PPC64LE.Fedora.Stable.PR|PPC64LE.RHEL8.LTO.+.PGO.PR |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 491a642 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
The PEP has been accepted, with a caveat about making it |
|
Congrats either way! |
166202e to
df88c8d
Compare
df88c8d to
cdfa1e7
Compare
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
| if name in ('Queue', 'QueueEmpty', 'QueueFull', 'create_queue'): | ||
| global create_queue, Queue, QueueEmpty, QueueFull | ||
| ns = globals() | ||
| from .queues import ( | ||
| from ._queues import ( | ||
| create as create_queue, | ||
| Queue, QueueEmpty, QueueFull, | ||
| ) |
There was a problem hiding this comment.
Is importing the interpreters.queues modules expensive enough to warrant the complexity of delayed imports & module-level __getattr__? If it is, we should also implement module-level __dir__.
If not though, I'd suggest just simplifying all of this into a regular import.
There was a problem hiding this comment.
Yeah, it might not matter so much. I'll take a look at dropping the module __getattr__.
|
!buildbot PPC64LE RHEL8 LTO + PGO |
|
The regex 'PPC64LE RHEL8 LTO + PGO' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
|
!buildbot PPC64LE RHEL8 LTO + PGO |
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit e4cbc66 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
I'll merge this once I've verified that buildbot passes. |
| try: | ||
| from test.support import interpreters | ||
| from concurrent import interpreters | ||
| except ImportError: | ||
| interpreters = None |
There was a problem hiding this comment.
Do we have a reason to expect this import will fail, or can we remove this condition? (Here and elsewhere.)
There was a problem hiding this comment.
Probably if _interpreters doesn't exist.
There was a problem hiding this comment.
Currently the module isn't supported on WASI and Emscripten builds. See gh-135190.
There was a problem hiding this comment.
And I've been waiting for Eric to try to turn it all on -- at least for WASI -- and see if it just works. 😉
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This is in case PEP-734 is accepted.