gh-134939: Add the interpreters Module #133958

ericsnowcurrently · 2025-05-13T01:45:43Z

This is in case PEP-734 is accepted.

Issue: Add the interpreters Module, Implementing PEP 734 #134939

bedevere-bot · 2025-05-27T18:19:57Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5c8545a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot · 2025-05-29T21:47:23Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c63b6bc 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

ericsnowcurrently · 2025-05-30T15:32:27Z

FTR, I ran this against the buildbots and there were two failures:

aarch64 RHEL8 Refleaks - https://buildbot.python.org/#/builders/802/builds/1730
wasm32-wasi Non-Debug - https://buildbot.python.org/#/builders/1373/builds/503

Neither looks related, but I'll rerun them just to be sure.

ericsnowcurrently · 2025-05-30T18:23:49Z

!buildbot aarch64 RHEL8 Refleaks

bedevere-bot · 2025-05-30T18:23:52Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

The command will test the builders whose names match following regular expression: aarch64 RHEL8 Refleaks

The builders matched are:

aarch64 RHEL8 Refleaks PR

ericsnowcurrently · 2025-05-30T18:24:00Z

!buildbot wasm32-wasi Non-Debug

bedevere-bot · 2025-05-30T18:24:03Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

The command will test the builders whose names match following regular expression: wasm32-wasi Non-Debug

The builders matched are:

wasm32-wasi Non-Debug PR

ZeroIntensity · 2025-06-06T20:18:44Z

Congrats either way!

Doc/library/concurrent.interpreters.rst

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Lib/concurrent/interpreters/_crossinterp.py

AA-Turner · 2025-06-06T21:15:15Z

Lib/concurrent/interpreters/__init__.py

    if name in ('Queue', 'QueueEmpty', 'QueueFull', 'create_queue'):
        global create_queue, Queue, QueueEmpty, QueueFull
        ns = globals()
-        from .queues import (
+        from ._queues import (
            create as create_queue,
            Queue, QueueEmpty, QueueFull,
        )


Is importing the interpreters.queues modules expensive enough to warrant the complexity of delayed imports & module-level __getattr__? If it is, we should also implement module-level __dir__.

If not though, I'd suggest just simplifying all of this into a regular import.

Yeah, it might not matter so much. I'll take a look at dropping the module __getattr__.

ericsnowcurrently · 2025-06-06T21:49:05Z

!buildbot PPC64LE RHEL8 LTO + PGO

bedevere-bot · 2025-06-06T21:49:08Z

The regex 'PPC64LE RHEL8 LTO + PGO' did not match any buildbot builder. Is the requested builder in the list of stable builders?

ericsnowcurrently · 2025-06-06T21:49:26Z

!buildbot PPC64LE RHEL8 LTO + PGO

bedevere-bot · 2025-06-06T21:49:29Z

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit e4cbc66 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

The command will test the builders whose names match following regular expression: PPC64LE RHEL8 LTO \+ PGO

The builders matched are:

PPC64LE RHEL8 LTO + PGO PR

ericsnowcurrently · 2025-06-06T23:10:55Z

I'll merge this once I've verified that buildbot passes.

Doc/library/concurrent.rst

Doc/library/concurrent.interpreters.rst

Doc/whatsnew/3.14.rst

Doc/library/concurrent.rst

Doc/whatsnew/3.14.rst

hugovk · 2025-06-08T17:05:43Z

Lib/test/test_threading.py

 try:
-    from test.support import interpreters
+    from concurrent import interpreters
 except ImportError:
    interpreters = None


Do we have a reason to expect this import will fail, or can we remove this condition? (Here and elsewhere.)

Probably if _interpreters doesn't exist.

Currently the module isn't supported on WASI and Emscripten builds. See gh-135190.

And I've been waiting for Eric to try to turn it all on -- at least for WASI -- and see if it just works. 😉

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

ericsnowcurrently · 2025-06-11T21:22:21Z

I'll merge this in a couple hours unless I hear any objections.

miss-islington-app · 2025-06-11T23:35:51Z

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2025-06-11T23:35:58Z

Sorry, @ericsnowcurrently, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 62143736b623fd0bcf998995196a13c4e50bb778 3.14

) PEP-734 has been accepted (for 3.14). (FTR, I'm opposed to putting this under the concurrent package, but doing so is the SC condition under which the module can land in 3.14.)

ericsnowcurrently added the needs backport to 3.14 bugs and security fixes label May 13, 2025

ericsnowcurrently force-pushed the pep-734-accepted branch 4 times, most recently from 7ddfb50 to 5c8545a Compare May 27, 2025 17:59

ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 27, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 27, 2025

ericsnowcurrently force-pushed the pep-734-accepted branch 2 times, most recently from 1e34abd to c63b6bc Compare May 29, 2025 20:56

ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2025

ericsnowcurrently force-pushed the pep-734-accepted branch from c63b6bc to ea9041c Compare May 30, 2025 15:30

ericsnowcurrently changed the title ~~Add the interpreters Module~~ gh-134939: Add the interpreters Module May 30, 2025

bedevere-app bot mentioned this pull request May 30, 2025

Add the interpreters Module, Implementing PEP 734 #134939

Open

4 tasks

ericsnowcurrently added 4 commits May 30, 2025 12:15

Move the interpreters module to the official stdlib.

e3aa50b

Add a NEWS entry.

88e47fb

Add a whatsnew entry.

ce3505b

Add initial docs.

0a5d0e4

ericsnowcurrently force-pushed the pep-734-accepted branch from ea9041c to 0a5d0e4 Compare May 30, 2025 18:16

ericsnowcurrently marked this pull request as ready for review May 30, 2025 19:30

ericsnowcurrently requested review from erlend-aasland, ezio-melotti and hugovk as code owners May 30, 2025 19:30

ericsnowcurrently force-pushed the pep-734-accepted branch from 166202e to df88c8d Compare June 6, 2025 20:35

interpreters -> concurrent.interpreters

cdfa1e7

ericsnowcurrently force-pushed the pep-734-accepted branch from df88c8d to cdfa1e7 Compare June 6, 2025 20:50

AA-Turner reviewed Jun 6, 2025

View reviewed changes

Doc/library/concurrent.interpreters.rst Outdated Show resolved Hide resolved

AA-Turner reviewed Jun 6, 2025

View reviewed changes

Doc/library/concurrent.interpreters.rst Outdated Show resolved Hide resolved

ericsnowcurrently and others added 2 commits June 6, 2025 15:12

Update Doc/library/concurrent.interpreters.rst

fe1c1ae

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Update Doc/library/concurrent.interpreters.rst

399042f

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

AA-Turner reviewed Jun 6, 2025

View reviewed changes

Lib/concurrent/interpreters/_crossinterp.py Show resolved Hide resolved

AA-Turner reviewed Jun 6, 2025

View reviewed changes

ericsnowcurrently added 2 commits June 6, 2025 15:23

Fix the NEWS entry.

907bb8c

Drop the module __getattr__.

e4cbc66

neonene reviewed Jun 7, 2025

View reviewed changes

Doc/library/concurrent.rst Outdated Show resolved Hide resolved

hugovk reviewed Jun 8, 2025

View reviewed changes

Apply suggestions from code review.

c0b637e

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

ericsnowcurrently merged commit 6214373 into python:main Jun 11, 2025
39 checks passed

github-project-automation bot moved this to Done in lavitaconnect@MOSTAFAAMMER Jun 11, 2025

bedevere-app bot removed the awaiting core review label Jun 11, 2025

ericsnowcurrently deleted the pep-734-accepted branch June 11, 2025 23:35

miss-islington-app bot assigned ericsnowcurrently Jun 11, 2025

ericsnowcurrently mentioned this pull request Jun 11, 2025

[3.14] gh-134939: Add the concurrent.interpreters Module #135414

Open

Uh oh!

gh-134939: Add the interpreters Module #133958

gh-134939: Add the interpreters Module #133958

Conversation

ericsnowcurrently commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented May 27, 2025

Uh oh!

bedevere-bot commented May 29, 2025

Uh oh!

ericsnowcurrently commented May 30, 2025

Uh oh!

ericsnowcurrently commented May 30, 2025

Uh oh!

bedevere-bot commented May 30, 2025

Uh oh!

ericsnowcurrently commented May 30, 2025

Uh oh!

bedevere-bot commented May 30, 2025

Uh oh!

ZeroIntensity commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently commented Jun 6, 2025

Uh oh!

bedevere-bot commented Jun 6, 2025

Uh oh!

ericsnowcurrently commented Jun 6, 2025

Uh oh!

bedevere-bot commented Jun 6, 2025

Uh oh!

ericsnowcurrently commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hugovk Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

brettcannon Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently commented Jun 11, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jun 11, 2025

Uh oh!

miss-islington-app bot commented Jun 11, 2025

Uh oh!

Uh oh!

ericsnowcurrently commented May 13, 2025 •

edited

Loading

AA-Turner Jun 6, 2025 •

edited

Loading