gh-116738: Make grp module thread-safe #135434
Open
+130
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I am not sure if there is a CI setup where |
colesbury
reviewed
Jun 16, 2025
Comment on lines
+170
to
+180
| #elif defined(Py_GIL_DISABLED) | ||
| static PyMutex getgrgid_mutex = {0}; | ||
| PyMutex_Lock(&getgrgid_mutex); | ||
| // The getgrgid() function need not be thread-safe. | ||
| // https://pubs.opengroup.org/onlinepubs/9699919799/functions/getgrgid.html | ||
| p = getgrgid(gid); | ||
| if (p == NULL) { | ||
| // Unlock the mutex on error. The following error handling block will | ||
| // handle the rest. | ||
| PyMutex_Unlock(&getgrgid_mutex); | ||
| } |
There was a problem hiding this comment.
I think we should use the lock in the default build as well. The thread safety issues here apply to multiple interpreters as well and this lock would address that.
| @@ -248,6 +261,17 @@ grp_getgrnam_impl(PyObject *module, PyObject *name) | |||
| } | |||
|
|
|||
| Py_END_ALLOW_THREADS | |||
| #elif defined(Py_GIL_DISABLED) | |||
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 269b454 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135434%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
grpmodule methodsgetgrgid()andgetgrnam()thread-safe when the GIL is disabled andgetgrgid_r()/getgrnam_r()C APIs are not available.Lib/test/test_free_threading/test_ft.pyto reuserun_concurrently()across multiple tests.cc: @mpage @colesbury @Yhg1s