Skip to content

gh-127146: Add skip_emscripten_stack_overflow in a few places #135722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

gh-127146: Add skip_emscripten_stack_overflow in a few places #135722

merged 1 commit into from
Jun 19, 2025
+2 −0

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 19, 2025 •
edited by bedevere-app bot
Loading

I don't reproduce these but Russell says he is getting failures in these tests.

@hoodmane
pythongh-127146: Add skip_emscripten_stack_overflow in a few places
edfe80d 
I don't reproduce these but Russell says he is getting failures
in these tests.
@hoodmane hoodmane requested a review from freakboy3742 June 19, 2025 15:46
@hoodmane hoodmane requested a review from iritkatriel as a code owner June 19, 2025 15:46
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jun 19, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 19, 2025
Open
@freakboy3742 freakboy3742 merged commit c8c13f8 into python:main Jun 19, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2025
@hoodmane @miss-islington
pythongh-127146: Add skip_emscripten_stack_overflow in a few places (p…
cea19ce 
…ythonGH-135722)

More tests that hit stack limits on some platforms.
(cherry picked from commit c8c13f8)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2025

GH-135733 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 19, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 19, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Add skip_emscripten_stack_overflow in a few places (G…
203753b 
…H-135722) (#135733)

More tests that hit stack limits on some platforms.
(cherry picked from commit c8c13f8)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742