From eff548cd2ea166179ed07afc3367dd7fe83fa676 Mon Sep 17 00:00:00 2001 From: Hansraj Das Date: Thu, 10 Oct 2019 01:02:59 +0530 Subject: [PATCH 1/3] bpo-38409: Grammatically correct help documentation of str.strip() * `remove` should be `removed` as done for lstrip and rstrip help docs --- .../next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst | 1 + Objects/clinic/unicodeobject.c.h | 2 +- Objects/unicodeobject.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst diff --git a/Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst b/Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst new file mode 100644 index 00000000000000..9be4b1ab4c5bbd --- /dev/null +++ b/Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst @@ -0,0 +1 @@ +Grammatically corrected help(str.strip) documentation. Patch by Hansraj Das diff --git a/Objects/clinic/unicodeobject.c.h b/Objects/clinic/unicodeobject.c.h index c7d6edb5fd488d..796384c68b909a 100644 --- a/Objects/clinic/unicodeobject.c.h +++ b/Objects/clinic/unicodeobject.c.h @@ -582,7 +582,7 @@ PyDoc_STRVAR(unicode_strip__doc__, "strip($self, chars=None, /)\n" "--\n" "\n" -"Return a copy of the string with leading and trailing whitespace remove.\n" +"Return a copy of the string with leading and trailing whitespace removed.\n" "\n" "If chars is given and not None, remove characters in chars instead."); diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 8d442fb6d82b8b..da1aa1f002b5f1 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -12544,7 +12544,7 @@ str.strip as unicode_strip chars: object = None / -Return a copy of the string with leading and trailing whitespace remove. +Return a copy of the string with leading and trailing whitespace removed. If chars is given and not None, remove characters in chars instead. [clinic start generated code]*/ From ca10922f52b43da686623360d547380443b8f91b Mon Sep 17 00:00:00 2001 From: Hansraj Das Date: Thu, 10 Oct 2019 01:27:30 +0530 Subject: [PATCH 2/3] Remove news blurb, skip-news label added to PR --- .../next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst | 1 - 1 file changed, 1 deletion(-) delete mode 100644 Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst diff --git a/Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst b/Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst deleted file mode 100644 index 9be4b1ab4c5bbd..00000000000000 --- a/Misc/NEWS.d/next/Documentation/2019-10-10-01-00-29.bpo-38409.UQgQk1.rst +++ /dev/null @@ -1 +0,0 @@ -Grammatically corrected help(str.strip) documentation. Patch by Hansraj Das From 2cfe6a1568a00bc85fa897f4dd68fbeb4ef19f47 Mon Sep 17 00:00:00 2001 From: Hansraj Das Date: Thu, 10 Oct 2019 01:52:51 +0530 Subject: [PATCH 3/3] make clinic executed to autogenerate dependent file Objects/clinic/unicodeobject.c.h * checksums also updated --- Objects/clinic/unicodeobject.c.h | 2 +- Objects/unicodeobject.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Objects/clinic/unicodeobject.c.h b/Objects/clinic/unicodeobject.c.h index 796384c68b909a..0d134064bab091 100644 --- a/Objects/clinic/unicodeobject.c.h +++ b/Objects/clinic/unicodeobject.c.h @@ -1232,4 +1232,4 @@ unicode_sizeof(PyObject *self, PyObject *Py_UNUSED(ignored)) { return unicode_sizeof_impl(self); } -/*[clinic end generated code: output=5e15747f78f18329 input=a9049054013a1b77]*/ +/*[clinic end generated code: output=e4ed33400979c7e8 input=a9049054013a1b77]*/ diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index da1aa1f002b5f1..2d60627b19193b 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -12551,7 +12551,7 @@ If chars is given and not None, remove characters in chars instead. static PyObject * unicode_strip_impl(PyObject *self, PyObject *chars) -/*[clinic end generated code: output=ca19018454345d57 input=eefe24a1059c352b]*/ +/*[clinic end generated code: output=ca19018454345d57 input=385289c6f423b954]*/ { return do_argstrip(self, BOTHSTRIP, chars); }