Skip to content

bpo-39850: Add support for abstract sockets in multiprocessing #18866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 9, 2020
Merged

bpo-39850: Add support for abstract sockets in multiprocessing #18866

merged 7 commits into from
Mar 9, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 9, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal force-pushed the bpo-39850 branch 2 times, most recently from 4c3361e to 338696b Compare March 9, 2020 01:49
@pablogsal pablogsal requested a review from pitrou March 9, 2020 01:49
@pablogsal pablogsal self-assigned this Mar 9, 2020
@pablogsal pablogsal force-pushed the bpo-39850 branch 5 times, most recently from 4fa7210 to 95575e1 Compare March 9, 2020 02:53
pitrou
pitrou reviewed Mar 9, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

@pitrou
Copy link
Member

pitrou commented Mar 9, 2020

By the way, I don't think this can be backported since it's a behaviour change. If we want to fix support for abstract sockets on 3.7-3.8 we'll need a different patch.

@pablogsal
Copy link
Member Author

@pitrou Would you like me to split this PR in two (one with the fix 'per se' and the other with the new default)?

Another possibility is that I create manually the backports, removing the new behaviour in the process.

vstinner
vstinner reviewed Mar 9, 2020
View reviewed changes
@pitrou
Copy link
Member

pitrou commented Mar 9, 2020

@pablogsal As is the most convenient for you.

pablogsal and others added 2 commits March 9, 2020 10:17
@pablogsal @vstinner
Update Lib/multiprocessing/util.py
5957b9b 
Co-Authored-By: Victor Stinner <vstinner@python.org>
@pablogsal @vstinner
Apply suggestions from code review
9a862b5 
Co-Authored-By: Victor Stinner <vstinner@python.org>
@pablogsal
Copy link
Member Author

LGTM. Thanks for all updates I asked for ;-)

Always happy to do them! Thanks for the review :)

@pablogsal pablogsal merged commit 6012f30 into python:master Mar 9, 2020
@pablogsal pablogsal deleted the bpo-39850 branch March 9, 2020 13:48
@AmirHmZz
Copy link

AmirHmZz commented Apr 3, 2020

So now does windows support AF_UNIX for IPC ?

@gpshead gpshead mentioned this pull request Oct 20, 2022
Merged
@nmichaels nmichaels mannequin mentioned this pull request Oct 20, 2022
Closed
This was referenced Oct 20, 2022
Merged
Merged
Merged
@tshu-w tshu-w mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@pitrou pitrou pitrou left review comments

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @pitrou @AmirHmZz @vstinner @the-knights-who-say-ni @bedevere-bot