Skip to content

bpo-39481: PEP 585 for a variety of modules #19423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2020
Merged

bpo-39481: PEP 585 for a variety of modules #19423

merged 3 commits into from
Apr 10, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Apr 7, 2020 •
edited by bedevere-bot
Loading

  • queue.SimpleQueue
  • queue.Queue
  • tempfile.TemporaryDirectory
  • unittest.case._AssertRaisesContext

https://bugs.python.org/issue39481

@isidentical isidentical requested a review from rhettinger as a code owner April 7, 2020 23:26
@isidentical isidentical requested a review from gvanrossum April 7, 2020 23:26
gvanrossum
gvanrossum approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once your other PR (#19418) lands you will have to rebase; then ping me and I'll land it.

@gvanrossum gvanrossum changed the title bpo-39481: Generic Alias for SimpleQueue, Queue, TemporaryDirectory... bpo-39481: PEP 585 for queue, tempfile, unittest Apr 10, 2020
@gvanrossum gvanrossum closed this Apr 10, 2020
@gvanrossum gvanrossum reopened this Apr 10, 2020
This was referenced Apr 10, 2020
Closed
Closed
@isidentical
Copy link
Member Author

For preventing future conflicts, appending group2 and 3s into this PR.

@isidentical isidentical requested a review from tiran as a code owner April 10, 2020 14:03
@isidentical isidentical requested a review from gvanrossum April 10, 2020 14:04
@gvanrossum gvanrossum changed the title bpo-39481: PEP 585 for queue, tempfile, unittest bpo-39481: PEP 585 for a variety of modules Apr 10, 2020
@gvanrossum gvanrossum merged commit 0361556 into python:master Apr 10, 2020
@cdce8p cdce8p mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isidentical @gvanrossum @emmatyping @the-knights-who-say-ni @bedevere-bot