Skip to content

bpo-40548: Always run GitHub action, even on doc PRs #19981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020
Merged

bpo-40548: Always run GitHub action, even on doc PRs #19981

merged 1 commit into from
May 7, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 7, 2020

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

https://bugs.python.org/issue40548

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.
@vstinner
Copy link
Member Author

vstinner commented May 7, 2020

cc @zooba @ammaraskar @pablogsal @brettcannon @Mariatta: sorry to ping many people, but I'm not sure who can/want to review this CI configuration change :-/

Copy link
Member

@ammaraskar ammaraskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as a temporary solution until someone has time to go port the workaround from Azure pipelines. Build times will go up for documentation-only PRs but that should be okay for now.

@vstinner vstinner merged commit 4e36376 into python:master May 7, 2020
@vstinner vstinner deleted the ghactions branch May 7, 2020 20:42
@vstinner
Copy link
Member Author

vstinner commented May 7, 2020

Thanks for the review @ammaraskar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants