Skip to content

Typo: fix inverted sense of statement #23288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2020
Merged

Typo: fix inverted sense of statement #23288

merged 2 commits into from
Nov 25, 2020

Conversation

basak
Copy link
Contributor

@basak basak commented Nov 14, 2020 •
edited by miss-islington
Loading

Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are not
needed.

Automerge-Triggered-By: GH:JulienPalard

@basak
Typo: fix inverted sense of statement
475ac5b 
Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are *not*
needed.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@basak

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 14, 2020
@basak
Copy link
Contributor Author

basak commented Nov 14, 2020

CLI signed, and I think you probably want "skip issue" and "skip news" for this.

@JulienPalard JulienPalard added the needs backport to 3.9 only security fixes label Nov 25, 2020
@JulienPalard
Copy link
Member

Hi @basak! Good catch and thanks for the PR!

@miss-islington
Copy link
Contributor

@basak: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9d09e17 into python:master Nov 25, 2020
@miss-islington
Copy link
Contributor

Thanks @basak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2020
@basak @miss-islington
Typo: fix inverted sense of statement (pythonGH-23288)
6c2803d 
Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are *not*
needed.

Automerge-Triggered-By: GH:JulienPalard
(cherry picked from commit 9d09e17)

Co-authored-by: basak <robie@justgohome.co.uk>
@bedevere-bot
Copy link

GH-23512 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 25, 2020
@rhettinger rhettinger added the needs backport to 3.9 only security fixes label Nov 25, 2020
@miss-islington
Copy link
Contributor

Thanks @basak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

rhettinger pushed a commit that referenced this pull request Nov 25, 2020
@miss-islington
Typo: fix inverted sense of statement (GH-23288) (GH-23512)
dca61e7
@Mariatta Mariatta removed the needs backport to 3.9 only security fixes label Dec 13, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@basak @adorilson
Typo: fix inverted sense of statement (pythonGH-23288)
385d66b 
Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are *not*
needed.

Automerge-Triggered-By: GH:JulienPalard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@basak @the-knights-who-say-ni @JulienPalard @miss-islington @bedevere-bot @rhettinger @Mariatta