Skip to content

bpo-37892: Use space indents in IDLE Shell #25678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Apr 28, 2021

Adding a newline to the prompt moves it out of the way of
user code input, which now starts at the left margin,
along with continuation lines.

https://bugs.python.org/issue37892

Adding a newline to the prompt moves it out of the way of
user code input, which now starts at the left margin,
along with continuation lines.
@terryjreedy terryjreedy added the type-bug An unexpected behavior, bug, or error label Apr 28, 2021
@terryjreedy terryjreedy self-assigned this Apr 28, 2021
@terryjreedy terryjreedy requested a review from taleinat April 28, 2021 04:39
@terryjreedy
Copy link
Member Author

@taleinat I hope I am not surprising you too much. Unless you find reason why not, I am inclined to merge this tomorrow and leave it to you to merge this in with master, add a toggle*, and test that this works with sidebar toggled off. Or make the 3 little changes to the other PR to test. Or I will tomorrow (it is 2:40 am here).

  • for the beta, I think we can skip configdialog, and instead add something like the following to the startup message.
Enter a statement on the line *after* the last '>>>' prompt.  Indents will be spaces instead of tabs.
Or hit Alt-? to try out the new Shell sidebar.  Doing so will clear this window.

Then switch to this addition.

Enter a statement to the right of the last '>>>' prompt.  But indents will be spaces instead of tabs.
Or hit Alt-? to return to the prompt above input mode.  Doing so will clear this window.

Actually, I intend to revise the current mostly useless help message. It could instead be removed and permanently replaced with something more useful. People should know about Help -> About.

@terryjreedy
Copy link
Member Author

For beta, we might mention sending feedback to idle-dev@python.org. (I just posted to that address to test and it worked.)

@gvanrossum
Copy link
Member

I tried this too. I think I have a slight preference for Tal's version (with the prompts in the margin) because in his version it's easier to distinguish input from output that way, and because it's easier to copy/paste blocks of code that span multiple prompts.

@terryjreedy
Copy link
Member Author

Shell with sidebar looks even better with proper indents.

@taleinat
Copy link
Contributor

taleinat commented May 1, 2021

@terryjreedy, this is great! (Sorry for not getting to comment on this earlier.)

I'm pleasantly surprised that this simple change appears to "just work" so nicely.

@terryjreedy
Copy link
Member Author

please merge origin/master into your branch to include this, and the test fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants