Skip to content

bpo-30570: Fix segfault on buildbots caused by stack overflow from recursion in tests #29258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2021
Merged

bpo-30570: Fix segfault on buildbots caused by stack overflow from recursion in tests #29258

merged 2 commits into from
Oct 28, 2021

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Oct 28, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 28, 2021
@sweeneyde sweeneyde added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 28, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 0f8697f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 28, 2021
@sweeneyde sweeneyde added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 28, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 7f4ebfa 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 28, 2021
@sweeneyde
Copy link
Member Author

@pablogsal I think this fixes a couple of the buildbot failures (s390x RHEL7).

@sweeneyde sweeneyde changed the title bpo-30570: Don't stackoveflow on debug builds bpo-30570: Fix segfault on buildbots caused by stack overflow from recursion in tests Oct 28, 2021
pablogsal
pablogsal approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sweeneyde for the PR!

I am still curious why it started segfaulting now. How are we consuming more stack size?

@pablogsal pablogsal merged commit d56375a into python:main Oct 28, 2021
@sweeneyde sweeneyde deleted the no_stackoverflow branch October 28, 2021 15:40
@sweeneyde
Copy link
Member Author

I don't know about the pickletester thing, but the test_isinstance bug was due to the test added in #29048. Maybe both have been intermittent/non-deterministic? Also, this should be backported, right?

@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 4, 2021
@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sweeneyde for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 4, 2021
@sweeneyde @miss-islington
bpo-30570: Fix segfault on buildbots caused by stack overflow from re…
f568b3b 
…cursion in tests (pythonGH-29258)

* Don't stackoveflow on debug builds

* Also catch the pickletester case
(cherry picked from commit d56375a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Sorry, @sweeneyde and @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d56375a0dd4cee162081b173310298a3d32af293 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 4, 2021
@bedevere-bot
Copy link

GH-29414 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit to ambv/cpython that referenced this pull request Nov 4, 2021
@sweeneyde @ambv
[3.9] bpo-30570: Fix segfault on buildbots caused by stack overflow f…
33cef69 
…rom recursion in tests (pythonGH-29258)

* Don't stackoveflow on debug builds

* Also catch the pickletester case.
(cherry picked from commit d56375a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
@bedevere-bot
Copy link

GH-29415 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 4, 2021
miss-islington added a commit that referenced this pull request Nov 4, 2021
@miss-islington @sweeneyde
bpo-30570: Fix segfault on buildbots caused by stack overflow from re…
1f3ae5c 
…cursion in tests (GH-29258)

* Don't stackoveflow on debug builds

* Also catch the pickletester case
(cherry picked from commit d56375a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
ambv added a commit that referenced this pull request Nov 4, 2021
@ambv @sweeneyde
[3.9] bpo-30570: Fix segfault on buildbots caused by stack overflow f…
f701237 
…rom recursion in tests (GH-29258) (GH-29415)

(cherry picked from commit d56375a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sweeneyde @bedevere-bot @miss-islington @pablogsal @ambv @the-knights-who-say-ni