From 0a580e6b05839ffd52d0cb6dc87fdabf805735e7 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Fri, 26 Nov 2021 11:50:34 +0100 Subject: [PATCH] bpo-45866: pegen strips directory of "generated from" header (GH-29777) "make regen-all" now produces the same output when run from a directory other than the source tree: when building Python out of the source tree. (cherry picked from commit 253b7a0a9fef1d72a4cb87b837885576e68e917c) --- .../next/Build/2021-11-25-13-53-36.bpo-45866.ZH1W8N.rst | 4 ++++ Parser/parser.c | 2 +- Tools/peg_generator/pegen/c_generator.py | 4 +++- Tools/peg_generator/pegen/grammar_parser.py | 2 +- Tools/peg_generator/pegen/python_generator.py | 4 +++- 5 files changed, 12 insertions(+), 4 deletions(-) create mode 100644 Misc/NEWS.d/next/Build/2021-11-25-13-53-36.bpo-45866.ZH1W8N.rst diff --git a/Misc/NEWS.d/next/Build/2021-11-25-13-53-36.bpo-45866.ZH1W8N.rst b/Misc/NEWS.d/next/Build/2021-11-25-13-53-36.bpo-45866.ZH1W8N.rst new file mode 100644 index 00000000000000..efa046d91e08e9 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2021-11-25-13-53-36.bpo-45866.ZH1W8N.rst @@ -0,0 +1,4 @@ +``make regen-all`` now produces the same output when run from a directory +other than the source tree: when building Python out of the source tree. +pegen now strips directory of the "generated by pygen from None: def generate(self, filename: str) -> None: self.collect_todo() - self.print(f"// @generated by pegen.py from {filename}") + basename = os.path.basename(filename) + self.print(f"// @generated by pegen.py from {basename}") header = self.grammar.metas.get("header", EXTENSION_PREFIX) if header: self.print(header.rstrip("\n")) diff --git a/Tools/peg_generator/pegen/grammar_parser.py b/Tools/peg_generator/pegen/grammar_parser.py index 70fa5b001b5c1c..892df5cf8ccca1 100644 --- a/Tools/peg_generator/pegen/grammar_parser.py +++ b/Tools/peg_generator/pegen/grammar_parser.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3.8 -# @generated by pegen from ./Tools/peg_generator/pegen/metagrammar.gram +# @generated by pegen from metagrammar.gram import ast from typing import Optional, Any diff --git a/Tools/peg_generator/pegen/python_generator.py b/Tools/peg_generator/pegen/python_generator.py index b500e3e204a5d4..4b270aa1e97416 100644 --- a/Tools/peg_generator/pegen/python_generator.py +++ b/Tools/peg_generator/pegen/python_generator.py @@ -1,3 +1,4 @@ +import os.path import token from typing import Any, Dict, Optional, IO, Text, Tuple @@ -139,7 +140,8 @@ def __init__( def generate(self, filename: str) -> None: header = self.grammar.metas.get("header", MODULE_PREFIX) if header is not None: - self.print(header.rstrip("\n").format(filename=filename)) + basename = os.path.basename(filename) + self.print(header.rstrip("\n").format(filename=basename)) subheader = self.grammar.metas.get("subheader", "") if subheader: self.print(subheader.format(filename=filename))