From 309ec06c8f63d53cf808ccdc990533fc4ab3f429 Mon Sep 17 00:00:00 2001 From: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Date: Tue, 25 Jan 2022 02:34:47 +0530 Subject: [PATCH] fixed flaky test (GH-30845) (cherry picked from commit 1c705fda8f9902906edd26d46acb0433b0b098e1) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> --- Lib/test/test_asyncio/test_sendfile.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py index c8bfa892c73fc6..effca6644c062e 100644 --- a/Lib/test/test_asyncio/test_sendfile.py +++ b/Lib/test/test_asyncio/test_sendfile.py @@ -92,9 +92,13 @@ async def wait_closed(self): class SendfileBase: - # 128 KiB plus small unaligned to buffer chunk - DATA = b"SendfileBaseData" * (1024 * 8 + 1) - + # 256 KiB plus small unaligned to buffer chunk + # Newer versions of Windows seems to have increased its internal + # buffer and tries to send as much of the data as it can as it + # has some form of buffering for this which is less than 256KiB + # on newer server versions and Windows 11. + # So DATA should be larger than 256 KiB to make this test reliable. + DATA = b"x" * (1024 * 256 + 1) # Reduce socket buffer size to test on relative small data sets. BUF_SIZE = 4 * 1024 # 4 KiB @@ -456,8 +460,6 @@ def test_sendfile_ssl_close_peer_after_receiving(self): # themselves). @unittest.skipIf(sys.platform.startswith('sunos'), "Doesn't work on Solaris") - @unittest.skipIf(sys.platform == "win32", - "It is flaky on Windows and needs to be fixed") # TODO: bpo-41682 def test_sendfile_close_peer_in_the_middle_of_receiving(self): srv_proto, cli_proto = self.prepare_sendfile(close_after=1024) with self.assertRaises(ConnectionError):