Skip to content

Change the xkcd link in comment over https. #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Conversation

Xdminsy
Copy link
Contributor

@Xdminsy Xdminsy commented Jan 30, 2018

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@miss-islington
Copy link
Contributor

Thanks @Xdminsy for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2018
(cherry picked from commit 83df50e)

Co-authored-by: 觉 <Xdminsy@users.noreply.github.com>
@bedevere-bot
Copy link

GH-9293 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2018
(cherry picked from commit 83df50e)

Co-authored-by: 觉 <Xdminsy@users.noreply.github.com>
@bedevere-bot
Copy link

GH-9294 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @Xdminsy and @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 83df50ea5757816c7338d27f21fd18b1e79206f7 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants