From 4b18e6e933a3304405f6231a7a1785dabe565dcd Mon Sep 17 00:00:00 2001 From: sweeneyde Date: Sat, 30 Apr 2022 16:39:07 -0400 Subject: [PATCH 1/2] use stderr as the assertion error message --- Lib/test/test_subprocess.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index 5814a6d924e128..e88ce27e0178ba 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -1743,7 +1743,7 @@ def test_encoding_warning(self): cp = subprocess.run([sys.executable, "-Xwarn_default_encoding", "-c", code], capture_output=True) lines = cp.stderr.splitlines() - self.assertEqual(len(lines), 2) + self.assertEqual(len(lines), 2, lines) self.assertTrue(lines[0].startswith(b":3: EncodingWarning: ")) self.assertTrue(lines[1].startswith(b":4: EncodingWarning: ")) From 345361683120f716eff920da6db456a49818d62f Mon Sep 17 00:00:00 2001 From: sweeneyde Date: Sat, 30 Apr 2022 17:59:49 -0400 Subject: [PATCH 2/2] use shell=True --- Lib/test/test_subprocess.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index e88ce27e0178ba..0764120952ebd9 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -1736,16 +1736,15 @@ def test_run_with_shell_timeout_and_capture_output(self): def test_encoding_warning(self): code = textwrap.dedent("""\ from subprocess import * - args = ["echo", "hello"] - run(args, text=True) - check_output(args, text=True) + run("echo hello", shell=True, text=True) + check_output("echo hello", shell=True, text=True) """) cp = subprocess.run([sys.executable, "-Xwarn_default_encoding", "-c", code], capture_output=True) lines = cp.stderr.splitlines() self.assertEqual(len(lines), 2, lines) - self.assertTrue(lines[0].startswith(b":3: EncodingWarning: ")) - self.assertTrue(lines[1].startswith(b":4: EncodingWarning: ")) + self.assertTrue(lines[0].startswith(b":2: EncodingWarning: ")) + self.assertTrue(lines[1].startswith(b":3: EncodingWarning: ")) def _get_test_grp_name():