-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values #98455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ethanfurman
commented
Oct 19, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Document new 3.11 enum APIs (ReprEnum, global_* and/or show_flag_values) #98298
@CAM-Gerlach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @ethanfurman ! I've added some suggestions for Sphinx syntax and formatting, and a couple wording clarifications on points that confused me initially as a non-enum-expert. I can't do so myself as I'm not a core dev, but you can review and apply them with just a couple clicks under Files
, click Add to Batch
then Commit
(or revise them with your own suggestions and apply those), and then feel free to merge, assuming I didn't make any syntax typos (there isn't a direct way for me to test them locally without committing them). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes for my error-causing typo, a change not applied before and one other point of confusion I noticed with my previous revision.
Also, FYI, you can avoid having to tediously apply the changes manually by just adding the suggestions to the batch under the Files tab, and then Commit
-ing them in one go—I'd hate for you to waste your valuable core dev time tediously implementing my minor fixes by hand. It will also auto-resolve the respective review suggestions, getting them out of the way.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach Cool, I didn't know about the batch committing of suggestions. |
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…values (pythonGH-98455) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> (cherry picked from commit 3e95ffc) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
GH-98530 is a backport of this pull request to the 3.11 branch. |