Skip to content

Commit a11f273

Browse files
authored
Merge pull request #1 from gioviebell/gioviebell-patch-1
GH-931: Update pull-request-lifecycle.rst PR title and description section
2 parents 65613fb + f1b556b commit a11f273

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

getting-started/pull-request-lifecycle.rst

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -213,24 +213,28 @@ should do to help ensure that your pull request is accepted.
213213
the other hand, fixes for typos and grammar errors in documents and
214214
docstrings are welcome.
215215

216-
#. **Follow best practices when creating the PR title and description.** The
217-
pull requests title and description play a pivotal role in code review and
216+
#. **Follow best practices when creating the PR title and description.** The
217+
pull requests title and description play a pivotal role in code review and
218218
issue resolution. It is the initial point of contact in a code review, and
219219
allows the code reviewer to quickly assess the issue. The suggested formatting
220-
of the title and description is
221-
**[type(optional) title: description (issue number)]** where type is the label
222-
associated with the issue being resolved. Based on `Best practices for
223-
writing good pull request titles`_, a pull request title should be descriptive but
224-
to the point. It should establish a clear yet brief summary, so to allow the code
225-
reviewer to quickly assess the pull request.
226-
The description should explain what was changed in the pull request, why it exists,
227-
and explain the process of what was done in the pull request.
228-
Here is an example of a poor and revised pull request description:
229-
**Poor Pull Request:** "update code" **Revised Pull Request:**
220+
of the title and description is
221+
222+
**GH-issue number: brief description of what the pull request resolves**
223+
224+
**Example: GH-123456: Use pure op machinery to optimize various instructions
225+
with _POP_TOP and _POP_TWO**
226+
227+
Based on `Best practices for writing good pull request titles`_, a pull request
228+
title should be descriptive but to the point. It should establish a clear yet brief
229+
summary, so to allow the code reviewer to quickly assess the pull request.
230+
The description should explain what was changed in the pull request, why it exists,
231+
and explain the process of what was done in the pull request.
232+
Here is an example of a poor and revised pull request description:
233+
**Poor Pull Request:** "update code" **Revised Pull Request:**
230234
"feat: add search functionality to user dashboard(closes #111)"
231235

232-
For more examples on writing a good pull request title, please take a look at
233-
`Best practices for
236+
For more examples on writing a good pull request title, please take a look at
237+
`Best practices for
234238
writing good pull request titles`_
235239

236240
To read more on creating a descriptive pull request description, please review

0 commit comments

Comments
 (0)