Skip to content

Broken "Copyright" link at the footer of DevGuide #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mariatta opened this issue Jan 14, 2021 · 4 comments
Closed

Broken "Copyright" link at the footer of DevGuide #652

Mariatta opened this issue Jan 14, 2021 · 4 comments
Labels
duplicate

Comments

@Mariatta
Copy link
Member

At the bottom of the Devguide, there is a link to Copyright that points to https://devguide.python.org/copyright/ which doesn't exist.

It would be great to fix that. Not even sure where it should go. Should it just point to the license? https://github.com/python/devguide/blob/master/LICENSE
@cyberShaw
Copy link

Can I work on this? I'm new to open source, and would love to contribute :D

@jablonskidev
Copy link
Contributor

@Mariatta I addressed this issue in the following PR in python-docs-theme:
python/python-docs-theme#67

Also, issues #652 and #653 for the devguide are duplicates of each other, so we'll be able to close two issues once this one is resolved.

@CAM-Gerlach CAM-Gerlach mentioned this issue Mar 13, 2021
Merged
jablonskidev added a commit to jablonskidev/devguide that referenced this issue Mar 20, 2021
@jablonskidev
Added copyright link for the devguide
ce0e204 
In order to resolve issues python#652 and python#653 in the devguide (which are duplicates of each other), we added a theme variable to `python_docs_theme/layout.html` in PR python#67. This will allow all users of the python-docs-theme library to have more functionality and backwards compatibility. In addition, if users don't define a link for copyright information, then they won't have a broken link that leads to nowhere in their page footer.

In order to have the correct copyright link for the devguide specifically, we just needed to specify it in the `html_theme_options` dictionary in the devguide's `conf.py`, which I did in this commit.
@jablonskidev jablonskidev mentioned this issue Mar 20, 2021
Closed
@za
Copy link
Contributor

za commented Oct 29, 2021

There's no hyperlink in the footer of Copyright now. Can we close this issue?

@hugovk
Copy link
Member

hugovk commented Jan 27, 2022

Closing as a duplicate of #653.

@hugovk hugovk closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@za @hugovk @Mariatta @cyberShaw @jablonskidev