-
-
Notifications
You must be signed in to change notification settings - Fork 848
Note when to backport changes #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Jacob. I agree with Victor's comments, this needs a few edits in the first instance.
A tip for using admonitions: they stand out and are highlighted, which means that using them must be done sparingly -- when is is most critical for a reader to be aware of a point? I think in this instance, backporting is not of sufficient import; so regular prose is fine. This is very akin to the boy who cried wolf, just in this instance replace the villagers with readers and the wolf with admonitions!
A
Thanks Adam, and understood. That makes sense - the use of admonitions is quite a bit different than I am used to 😄 |
Please re-review at your earliest convenience to see if it is in line with what we want to communicate |
6a97bbd
to
35e855b
Compare
Please avoid force-pushing, it makes reviewing in the GH interface much harder. PRs are squash merged. A |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A
Closes
Changes visualized:
Dev. Cycle📚 Documentation preview 📚: https://cpython-devguide--1169.org.readthedocs.build/