Skip to content

Commit ebdf7d1

Browse files
committed
Remove some now out-of-date comments
1 parent afe715d commit ebdf7d1

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

mypy/build.py

-14
Original file line numberDiff line numberDiff line change
@@ -1065,7 +1065,6 @@ def validate_meta(meta: Optional[CacheMeta], id: str, path: Optional[str],
10651065
manager.log('Metadata abandoned for {}: data cache is modified'.format(id))
10661066
return None
10671067

1068-
# TODO: Share stat() outcome with find_module()
10691068
path = os.path.abspath(path)
10701069
st = manager.get_stat(path) # TODO: Errors
10711070
if not stat.S_ISREG(st.st_mode):
@@ -1310,14 +1309,6 @@ def delete_cache(id: str, path: str, manager: BuildManager) -> None:
13101309
d. from P import M; checks filesystem whether module P.M exists in
13111310
filesystem.
13121311
1313-
e. Race conditions, where somebody modifies a file while we're
1314-
processing. I propose not to modify the algorithm to handle this,
1315-
but to detect when this could lead to inconsistencies. (For
1316-
example, when we decide on the dependencies based on cache
1317-
metadata, and then we decide to re-parse a file because of a stale
1318-
dependency, if the re-parsing leads to a different list of
1319-
dependencies we should warn the user or start over.)
1320-
13211312
Steps
13221313
-----
13231314
@@ -1852,11 +1843,6 @@ def compute_dependencies(self) -> None:
18521843
if self.id != 'builtins' and 'builtins' not in dep_line_map:
18531844
dependencies.append('builtins')
18541845

1855-
# NOTE: What to do about race conditions (like editing the
1856-
# file while mypy runs)? A previous version of this code
1857-
# explicitly checked for this, but ran afoul of other reasons
1858-
# for differences (e.g. silent mode).
1859-
18601846
# Missing dependencies will be moved from dependencies to
18611847
# suppressed when they fail to be loaded in load_graph.
18621848
self.dependencies = dependencies

0 commit comments

Comments
 (0)