Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python/mypy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: python/mypy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mypy-pin-cherrypick
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 8 files changed
  • 1 contributor

Commits on May 8, 2025

  1. Consolidate descriptor handling in checkmember.py (#18831) 

    This is not a pure refactoring, but almost. Right now we are in a weird
situation where we have two inconsistencies:
* `__set__()` is handled in `checker.py` while `__get__()` is handled in
`checkmember.py`
* rules for when to use binder are slightly different between
descriptors and settable properties.

This PR fixes these two things. As a nice bonus we should get free
support for unions in `__set__()`.
    @ilevkivskyi @jhance
    ilevkivskyi authored and jhance committed May 8, 2025
    Configuration menu
    Copy the full SHA
    3010efc View commit details
    Browse the repository at this point in the history

  2. Local forward refs should precede global forward refs (#19000) 

    Fixes #18988

This should be a minimal change to restore backwards compatibility for
an edge case with forward references.
    @ilevkivskyi @jhance
    ilevkivskyi authored and jhance committed May 8, 2025
    Configuration menu
    Copy the full SHA
    8e7c094 View commit details
    Browse the repository at this point in the history

  3. Do not narrow types to Never with binder (#18972) 

    Fixes #18967
Fixes #16494
Fixes #15793
Fixes #12949

As you can see from updated test cases, it is kind of gray area, so
whether we go this way will depend on the `mypy_primer` results (and
also potentially on Dropbox internal code bases, where the above issue
may cause problems).
    @ilevkivskyi @jhance
    ilevkivskyi authored and jhance committed May 8, 2025
    Configuration menu
    Copy the full SHA
    ea8aacd View commit details
    Browse the repository at this point in the history
Loading