Skip to content

__match_args__ and overrides #12008

Closed
@JelleZijlstra

Description

@JelleZijlstra

#10191 introduced a new false positive:

steam.py (https://github.com/Gobot1234/steam.py)
+ steam/profile.py:204: error: Cannot override final attribute "__match_args__" (previously declared in base class "EquippedProfileItems")  [misc]
+ steam/profile.py:204: error: Cannot override writable attribute "__match_args__" with a final one  [misc]
+ steam/profile.py:204: error: Definition of "__match_args__" in base class "ProfileInfo" is incompatible with definition in base class "EquippedProfileItems"  [misc]

Some further discussion in #10191 (comment).

I think we should just always allow overriding __match_args__, because it's only looked up on concrete classes, so overriding it is always safe.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions