You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# mypy: assert=platform == "win32" and python_version >= "3.10"
and the file would only be checked if sys.platform is win32 and the tuple sys.version_info is greater than or equal to (3, 10). This is similar to the environment markers used in dependency definitions but with only support for the two static platform variables that are already used by Mypy.
Implementation-wise, there would be a pre-processing step that transforms the Python version string (if present) into a tuple. This way you can pass those two variables directly to eval.
Pitch
This would significantly help in situations such as #19009. Brief recap:
and attempt importing this symbol from somewhere else, Mypy does not respect the platform condition.
For example, if you call pty.openpty() inside my_pkg._pty.unix and run Mypy on Windows it will show:
Module has no attribute "openpty" [attr-defined]
The best solution available is adding a top-level assertion as introduced here. For example, on top of the module my_pkg._pty.unix you would put assert sys.platform != "win32".
This is suboptimal because it requires modifying runtime behavior. The sys import is required, perhaps only for the assertion, and if there are imports that only exist conditionally the assertion has to be in the middle of the standard import block on top.
Adding a file-level comment is the most pragmatic option at hand, in lieu of adding an option that automatically propagates conditional static assertions to enclosed imports.
The text was updated successfully, but these errors were encountered:
as equivalent to top-level assert. It won't be a trivial change, but might still be easier than assert.
(beware of https://peps.python.org/pep-0781/ - should it get accepted, typing import won't be necessary too, this will be almost a no-op at runtime - simple if condition evaluation, insignificant for the import time)
That would indeed be nicer than the current situation but it still requires 3 lines of code and would still have to be inserted before imports that don't exist without the condition.
Feature
One would be able to do:
# mypy: assert=platform == "win32" and python_version >= "3.10"
and the file would only be checked if
sys.platform
iswin32
and the tuplesys.version_info
is greater than or equal to(3, 10)
. This is similar to the environment markers used in dependency definitions but with only support for the two static platform variables that are already used by Mypy.Implementation-wise, there would be a pre-processing step that transforms the Python version string (if present) into a tuple. This way you can pass those two variables directly to
eval
.Pitch
This would significantly help in situations such as #19009. Brief recap:
The best solution available is adding a top-level assertion as introduced here. For example, on top of the module
my_pkg._pty.unix
you would putassert sys.platform != "win32"
.This is suboptimal because it requires modifying runtime behavior. The
sys
import is required, perhaps only for the assertion, and if there are imports that only exist conditionally the assertion has to be in the middle of the standard import block on top.Adding a file-level comment is the most pragmatic option at hand, in lieu of adding an option that automatically propagates conditional static assertions to enclosed imports.
The text was updated successfully, but these errors were encountered: