Skip to content

Error message for incorrectly returning Any does not format types correctly #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OddBloke opened this issue Aug 31, 2017 · 1 comment · Fixed by #3910
Closed

Error message for incorrectly returning Any does not format types correctly #3899

OddBloke opened this issue Aug 31, 2017 · 1 comment · Fixed by #3910

Comments

@OddBloke
Copy link
Contributor

Consider this contrived example:

from typing import Any, Tuple

typ = Tuple[int, int, int, int, int, int, int, int, int, int, int, int, int,
            int, int, int, int, int, int, int, int, int, int, int, int, int,
            int, int, int, int, int, int, int, int, int, int, int, int, int,
            int, int, int, int, int, int, int, int, int, int, int, int, int,
            int, int, int, int, int, int, int, int, int, int, int, int, int,
            int, int, int, int, int, int, int, int, int, int, int, int, int,
            int, int, int, int, int, int, int, int, int, int, int, int, int]


def foo() -> typ:
    x = None  # type: Any
    return x

foo() + 3

mypy --strict currently outputs:

2.py:15: warning: Returning Any from function with declared return type "Tuple[builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int, builtins.int]"
2.py:17: error: Unsupported operand types for + (tuple(length 91) and "int")

The first line should be shortened the same way that the second line is (and were it not to be shortened, each element should be displayed as int, not builtins.int).
@OddBloke
Copy link
Contributor Author

This should be easy enough to fix, I think; mypy/checker.py:2018 currently does a direct string format when it should instead use the MessageBuilder format logic.

(There are probably a few other cases where this is happening with other constants, I'll see if I can catch any of those as well.)

@OddBloke OddBloke mentioned this issue Sep 2, 2017
Merged
ilevkivskyi pushed a commit that referenced this issue Sep 2, 2017
@OddBloke @ilevkivskyi
Format types nicely in incorrectly-returning-Any warning (#3910)
be5c456 
This fixes #3899 by using the same formatting as for other messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format types nicely in incorrectly-returning-Any warning OddBloke/mypy
1 participant
@OddBloke