Skip to content

Protocol requires __slots__ to be explicitly typed #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthewvalentine opened this issue Aug 5, 2019 · 1 comment · Fixed by #9314
Closed

Protocol requires __slots__ to be explicitly typed #7290

matthewvalentine opened this issue Aug 5, 2019 · 1 comment · Fixed by #9314
Labels
bug mypy got something wrong priority-2-low topic-protocols

Comments

@matthewvalentine
Copy link

Bug report. Mypy version: mypy 0.730+dev.445020f0ed9939b43371edbddcf5b083a706d6d8

Code:

class A(Protocol):
    __slots__ = ()

Expected:

Passes, and __slots__ is not part of the Protocol interface. It's just being provided to prevent subclasses from being forced to have a __dict__.

Actual:

error: All protocol members must have explicitly declared types
@msullivan msullivan added bug mypy got something wrong priority-2-low labels Aug 6, 2019
@msullivan
Copy link
Collaborator

This is a definitely a bug, though should be easy to work around with a type: ignore. It should be pretty easy to fix if you want to take a look

@sobolevn sobolevn mentioned this issue Aug 16, 2020
Merged
JukkaL pushed a commit that referenced this issue Aug 28, 2020
@sobolevn @hauntsaninja
Allow protocols with untyped "__slots__" (#9314)
55cffc1 
Closes #7290.

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@deannagarcia deannagarcia mentioned this issue Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong priority-2-low topic-protocols
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes protocols with untyped slots
3 participants
@msullivan @matthewvalentine @ilevkivskyi