Complain about inferring UninhabitedType for a variable #4112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't really make sense as variable types, most of the time. Also, don't turn them into partial None types, since UninhabitedType and None no longer have any correspondence.
|
Don't merge yet -- I want to fix an issue in internal Dropbox code first. |
|
So does this fix the problem with: def f() -> T: pass
x = f()
reveal_type(x) # NoneIf yes then maybe it makes sense to add a test for this? |
|
Yes, there is an existing test case that was skipped ( |
|
Updated the description to mention that this fixes #4104. |
|
Ah, OK, but then #4059 should be updated after you merge this, since the |
ilevkivskyi
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't really make sense as variable types, most of the time.
Also, don't turn them into partial None types, since UninhabitedType
and None no longer have any correspondence.
Fixes #4104.