Skip to content

no-issue: Migrate to the pyproject.toml #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 5, 2022
Merged

no-issue: Migrate to the pyproject.toml #249

merged 4 commits into from
Dec 5, 2022

Conversation

corona10
Copy link
Member

No description provided.

@corona10
Copy link
Member Author

The next works will be adding the auto-release pipeline like pyperf: https://github.com/psf/pyperf/blob/main/.github/workflows/publish.yml

Can I get access to PyPI owner page?

@corona10
Copy link
Member Author

corona10 commented Nov 29, 2022 •
edited
Loading

test / ubuntu-latest - 3.12-dev (pull_request) is the expected failure.

@ericsnowcurrently
Copy link
Member

The next works will be adding the auto-release pipeline like pyperf:

a big +1

ericsnowcurrently
ericsnowcurrently reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments.

Also, presumably you verified that the distribution package generated via pyproject.toml is identical to the one generated via setup.py.

@corona10 corona10 mentioned this pull request Nov 30, 2022
Closed
corona10 and others added 3 commits November 30, 2022 11:14
ericsnowcurrently
ericsnowcurrently approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 merged commit b1aff44 into python:main Dec 5, 2022
@corona10 corona10 deleted the pyproject branch December 5, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@mdboom mdboom Awaiting requested review from mdboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @ericsnowcurrently