Skip to content

Traducción completa de library/xml.etree.elementtree.po #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 3, 2021
Merged

Traducción completa de library/xml.etree.elementtree.po #1229

merged 13 commits into from
Aug 3, 2021

Conversation

mmmarcos
Copy link
Collaborator

@mmmarcos mmmarcos commented May 21, 2021 •
edited
Loading

Closes #317

@mmmarcos mmmarcos closed this Jul 18, 2021
@mmmarcos mmmarcos reopened this Jul 18, 2021
@mmmarcos mmmarcos marked this pull request as ready for review July 18, 2021 20:46
@mmmarcos mmmarcos changed the title Traducción de library/xml.etree.elementtree.po Traducción completa de library/xml.etree.elementtree.po Jul 18, 2021
cacrespo
cacrespo requested changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@cacrespo cacrespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendo trabajo! 💪
Van algunas sugerencias. De ningún modo las tomes como algo obligatorio. Si no te parecen adecuadas no impactes.

WIP - revisado hasta línea 500.

cacrespo
cacrespo requested changes Jul 25, 2021
View reviewed changes
Copy link
Collaborator

@cacrespo cacrespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP - revisado hasta línea 800.

mmmarcos and others added 2 commits July 31, 2021 21:24
@mmmarcos @cacrespo
Apply suggestions from code review
c86d7b3 
Co-authored-by: Carlos A. Crespo <lvccrespo@gmail.com>
@mmmarcos
Correción problema de powrap
78a5e20
@mmmarcos
Copy link
Collaborator Author

@cacrespo perfecto, apliqué todas las sugerencias salvo la de "tipo documento"/"tipo de documento" porque también estoy en duda con respecto al término "file-like object" mas adelante en el archivo.

BTW intenté aplicar las sugerencias directamente desde la interfaz de Github pero claro, no funciona porque hay que pasar powrap para que los checks pasen 😑

cacrespo
cacrespo requested changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@cacrespo cacrespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisión finalizada. Como mencioné anteriormente: son solo sugerencias.
Muchas gracias por el tremendo trabajo. 🥳🥳🥳

@mmmarcos mmmarcos requested a review from cacrespo August 3, 2021 15:47
@mmmarcos
Copy link
Collaborator Author

mmmarcos commented Aug 3, 2021

@cacrespo ya traté todos las sugerencias. Se necesita un nuevo OK para mergear ?

@cacrespo cacrespo merged commit aecf1c1 into python:3.9 Aug 3, 2021
cmaureir pushed a commit that referenced this pull request Aug 4, 2021
@mmmarcos @cmaureir
Traducción completa de library/xml.etree.elementtree.po (#1229)
a1904fe
@mmmarcos mmmarcos deleted the traduccion-xml-etree-elementtree branch October 29, 2022 11:39
@mmmarcos mmmarcos restored the traduccion-xml-etree-elementtree branch October 29, 2022 11:39
@mmmarcos mmmarcos deleted the traduccion-xml-etree-elementtree branch October 29, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacrespo cacrespo cacrespo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/xml.etree.elementtree.po
2 participants
@mmmarcos @cacrespo