Skip to content

Completing the built-in functions file (library/functions.po) #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
May 22, 2020

Conversation

clacri
Copy link
Contributor

@clacri clacri commented May 13, 2020

I'm aiming to finish this as soon as possible but will split in different PR. This one can be reviewed.

First part of issue #61

Closes #61

@clacri clacri marked this pull request as draft May 13, 2020 18:16
@clacri clacri marked this pull request as ready for review May 17, 2020 21:46
@hectorcanto
Copy link
Contributor

Lo revisaré en breve

@hectorcanto
Copy link
Contributor

me encanta invocable como substituto de callable, ¿lo has puesto en la memoria?

@hectorcanto
Copy link
Contributor

Revisión de lo que está hasta ahora, @clacri . Buen trabajo!!

clacri and others added 5 commits May 21, 2020 19:38
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
@clacri
Copy link
Contributor Author

clacri commented May 21, 2020

Revisión de lo que está hasta ahora, @clacri . Buen trabajo!!

muchas gracias hector, metere tus sugerencias y revisare las propuestas, y cuando esté eso y arregle el build ya lo dejo que hagan un primer merge y abro otra PR el finde para la otra mitad

clacri and others added 2 commits May 21, 2020 20:55
@clacri
Copy link
Contributor Author

clacri commented May 21, 2020

me encanta invocable como substituto de callable, ¿lo has puesto en la memoria?

ya estaba puesto por el glosario pero he añadido que lo he usado así también en functions.po

@clacri
Copy link
Contributor Author

clacri commented May 22, 2020

soy incapaz de encontrar lo que está causando el error en el build :(

clacri and others added 3 commits May 22, 2020 14:19
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
If you look closer, the ones that I'm deleting are not related to any line
number in the .rst file. That's why Sphinx was failing on these.
Note that this adds some paragraphs that I removed in the previous commit.
@humitos
Copy link
Collaborator

humitos commented May 22, 2020

I'm going to merge this PR since it's already reviewed. I was able to fix the issue with broken link. I'm not super happy with the solution, since I'm not 100% sure to understand it, because I removed some paragraphs that I thought it were wrong and they were re-added automatically when I upgraded the translation from the sources.

Anyways, good news is that we can continue working now!

@humitos humitos merged commit caeeb79 into 3.8 May 22, 2020
@humitos humitos deleted the claudia_finish_functions branch May 22, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translating library/functions.po
4 participants