Skip to content

This PR will finish the builtin functions po in library #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Jun 20, 2020
Merged

This PR will finish the builtin functions po in library #331

merged 59 commits into from
Jun 20, 2020

Conversation

clacri
Copy link
Contributor

@clacri clacri commented May 23, 2020 •
edited by humitos
Loading

It is still a draft, to be completed at some point soon.... But feel free to comment and review whatever is there already, as it is a very long file.

This is now part of a pair translation approach together with @draentropia

Notas para mí a repasar luego sobre el fichero completo:

  • retornar en vez de devolver
  • lo de los auditing event, y en general que no haya terminos de los que si tenia que hacer la traduccion

Close #61

@clacri clacri marked this pull request as draft May 23, 2020 00:07
cmaureir
cmaureir reviewed May 23, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sé que es un WIP, pero espero estos cambios te sirvan para la nueva versión. Gracias :)

clacri and others added 2 commits May 24, 2020 01:01
@clacri @cmaureir
Update library/functions.po
99c4082 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@clacri @cmaureir
Update library/functions.po
9b2b0f7 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
clacri
clacri commented May 23, 2020
View reviewed changes
clacri and others added 17 commits May 24, 2020 01:05
@clacri @cmaureir
Apply suggestions from code review
44cb729 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@clacri
after solving conflicts in dicts
2f47d66
@clacri
test commit
19fd98f
@clacri
solve build because something was half-translated
8df49ee
@clacri
a little bit more of open, ord and pow
009c76f
@clacri
solving post pulling conflict
dc673b0
@clacri
solving post pulling dict
00dc948
@clacri
solved the build hopefully
b2d73c2
@clacri
a little bit more of open and some words to memory
45d8fa1
@clacri
finally open completed
4623f1b
@clacri
Merge branch '3.8' of https://github.com/python/python-docs-es into f…
ff3d6e5 
…unclaudia
@clacri
after pair translating
a410d73
@clacri
Merge branch '3.8' of https://github.com/python/python-docs-es into f…
f53bee5 
…unclaudia
@clacri
Merge branch '3.8' of https://github.com/python/python-docs-es into f…
7cfcd49 
…unclaudia
@clacri
last commit
7658e4b
@clacri
Merge branch '3.8' of https://github.com/python/python-docs-es into f…
dd2fda3 
…unclaudia
@clacri
a little bit more advanced thanks to pair programming
799127e
raulcd
raulcd reviewed Jun 6, 2020
View reviewed changes
Copy link
Collaborator

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya quedan poquitos!!! 💪💪💪💪💪

clacri and others added 4 commits June 13, 2020 15:02
@clacri @humitos
Update library/functions.po
a8a1534 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
0fd9c13 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
7955b89 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
cdda465 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
clacri
clacri commented Jun 13, 2020
View reviewed changes
clacri and others added 12 commits June 13, 2020 15:39
@clacri
Update library/functions.po
f131155
@clacri @humitos
Update library/functions.po
2365b4c 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
5232f52 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
5c5e40a 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
fa4a846 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
968f4a6 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri @humitos
Update library/functions.po
77fa153 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri
Merge branch '3.8' of https://github.com/python/python-docs-es into f…
fce222e 
…unclaudia
@clacri
changed devuelve por retorna
eee26a8
@clacri
el iterador se detiene
ae6167b
@clacri @humitos
Update library/functions.po
a11e31f 
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@clacri
corrección slice y clase
a32a65c
@clacri
Copy link
Contributor Author

clacri commented Jun 13, 2020

He incluido las cosas que me has comentado, me queda pendiente en las que te he contestado y aun no hemos confirmado, y revisar el formato :)

@clacri
Copy link
Contributor Author

clacri commented Jun 14, 2020

@humitos estoy viendo párrafos que se quedan en inglés cuando miro el build de read the docs... porque podría ser?

@humitos
Copy link
Collaborator

humitos commented Jun 14, 2020

estoy viendo párrafos que se quedan en inglés cuando miro el build de read the docs... porque podría ser?

Si el párrafo está marcado como fuzzy va a aparecer en inglés por ahora. Hay un issue reportado para esto https://www.python.org/dev/peps/pep-0545/#enhance-rendering-of-untranslated-and-fuzzy-translations

Si son otros párrafos, decime.

@clacri
Copy link
Contributor Author

clacri commented Jun 14, 2020

ah bueno pero entonces me reviso los fuzzy porque algunos ya con tu revisión no creo que lo sean. gracias!!!

clacri
clacri commented Jun 14, 2020
View reviewed changes
@clacri
Copy link
Contributor Author

clacri commented Jun 15, 2020

Buenos días @humitos :)
me he revisado los fuzzy que tenía, y algunos los he quitados pero otros quería que les echaras un vistazo rápido, en concreto los de los párrafos:

  • 257
  • 295
  • 559
  • 697
    -704
  • 1329

@humitos
Copy link
Collaborator

humitos commented Jun 20, 2020

¡Me parece excelente el trabajo que hiciste con este módulo, @clacri! Sos una genia 😄. Aunque hayan 5 párrafors que están con fuzzy aún, creo que como hablamos en el chat, es mejor hacer el merge, así ya tenemos esto público y luego abrimos otra PR para trabajar en esos 5 párrafos en vez de bloquear tooooda la PR por esos 5 nomás.

Si no me equivoco, con esta PR mergeada tendríamos que ya poder estar online en el selector de la documentación oficial. ¡Gran trabajo!

@humitos humitos merged commit 6e68f8a into 3.8 Jun 20, 2020
@humitos humitos deleted the funclaudia branch June 20, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaureir cmaureir cmaureir left review comments

@raulcd raulcd raulcd left review comments

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translating library/functions.po
4 participants
@clacri @humitos @cmaureir @raulcd